Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python Python Basics (2015) Shopping List App Refactor

Didier Borel
Didier Borel
2,837 Points
Posted by Didier Borel
Didier Borel
2,837 Points

refactor

I still don't understand why this is incorrect. I have def main(): and all my code is inside the function. can you help?

shopping_list.py 
def show_help():
    # print out instructions on how to use the app
    print("What should we pick up at the store?")
    print("""
Enter 'DONE' to stop adding items.
Enter 'HELP' for this help.
Enter 'SHOW' to see your current list.
""")

def show_list(shopping_list):
    # print out the list
    print("Here's your list:")

    for item in shopping_list:
        print(item)

def add_to_list(shopping_list, new_item):
    # add new items to our list
    shopping_list.append(new_item)
    print("Added {}. List now has {} items.".format(new_item, len(shopping_list)))
    return shopping_list
def main():   
   show_help()

# make a list to hold onto our items
  shopping_list = []

    while True:
    # ask for new items
    new_item = input("> ")

    # be able to quit the app
    if new_item == 'DONE':
        break
    elif new_item == 'HELP':
        show_help()
        continue
    elif new_item == 'SHOW':
        show_list(shopping_list)
        continue
    add_to_list(shopping_list, new_item)

  show_list(shopping_list)
Grigorij Schleifer
Grigorij Schleifer
10,365 Points
Grigorij Schleifer
Grigorij Schleifer
10,365 Points

Here is a good link to read about indentation rules:

3 Answers

Grigorij Schleifer
Grigorij Schleifer
10,365 Points
Grigorij Schleifer
Grigorij Schleifer
10,365 Points

Hi Didier,

I have modified your main method:

def main():
    show_help()

    shopping_list = []

    while True:
        new_item = input("> ")

        if new_item == 'DONE':
            break
        elif new_item == 'HELP':
            show_help()
            continue
        elif new_item == 'SHOW':
            show_list(shopping_list)
            continue
# indent the if statements in the while loop block
        add_to_list(shopping_list, new_item)
# indent the  add_to_list method in the while loop block

    show_list(shopping_list)
# indent the show_list method in the main method block

Makes sense?

Grigorij

Didier Borel
Didier Borel
2,837 Points
Didier Borel
Didier Borel
2,837 Points

ok thxs Grigorij, so it was a problem of indentation, thxs

Grigorij Schleifer
Grigorij Schleifer
10,365 Points
Grigorij Schleifer
Grigorij Schleifer
10,365 Points

Hey,

you are welcome ! See you in the forum

G

Didier Borel
Didier Borel
2,837 Points
Didier Borel
Didier Borel
2,837 Points

did you paste in the link? i don't see it, but thxs - very helpful