Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript Basics (Retired) Creating Reusable Code with Functions Create a max() Function

Returning the largest number in the function

I am suppose to write a max function that has two arguments and those arguments are suppose to be numbers. I am suppose to return the largest of the number, however this particular function is not working. Please point me to the right direction.

script.js
function max(upper, lower) {
  var upper = '';
  var lower = '';
  if(upper > lower) {
     return upper  
  }
}
max(3,2)

1 Answer

Rahul Saini
Rahul Saini
4,611 Points

var upper = ''; var lower = ''; these are the same variable name, you are using in the argument, which got re-assigned to ''. You can use this.

function max(upper, lower) {
    return (upper>lower)? upper : lower;
}

Christopher Anderson ,

rahul saini answer is correct, however if you haven't used ternary operators before I just wanted to give you the example as a normal function. If you're all over ternary operators then disregard!

function max(upper, lower) {
  if (upper > lower) {
     return upper  
  }
     return lower; 
}
max(3,2)