Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript and the DOM (Retiring) Getting a Handle on the DOM Practice Selecting Elements

Shardul Nandapurkar
Shardul Nandapurkar
969 Points
Posted by Shardul Nandapurkar
Shardul Nandapurkar
969 Points

Selecting Links

Don understand where i am going wrong with my code.I have used the write tag in selection.And the for loop ok as well.

Thanks in Advance.

js/app.js 
let navigationLinks = document.getElementByTagName('a');
    for(let i = 0; i < navigationLinks.length i += 1) {
    navigationLinks[i]
  }
let galleryLinks;
let footerImages;
index.html 
<!DOCTYPE html>
<html>
  <head>
    <meta charset="utf-8">
    <title>Nick Pettit | Designer</title>
    <link rel="stylesheet" href="css/normalize.css">
    <link href='http://fonts.googleapis.com/css?family=Changa+One|Open+Sans:400italic,700italic,400,700,800' rel='stylesheet' type='text/css'>
    <link rel="stylesheet" href="css/main.css">
    <link rel="stylesheet" href="css/responsive.css">
    <meta name="viewport" content="width=device-width, initial-scale=1.0">
  </head>
  <body>
    <header>
      <a href="index.html" id="logo">
        <h1>Nick Pettit</h1>
        <h2>Designer</h2>
      </a>
      <nav>
        <ul>
          <li><a href="index.html" class="selected">Portfolio</a></li>
          <li><a href="about.html">About</a></li>
          <li><a href="contact.html">Contact</a></li>
        </ul>
      </nav>
    </header>
    <div id="wrapper">
      <section>
        <ul id="gallery">
          <li>
            <a href="img/numbers-01.jpg">
              <img src="img/numbers-01.jpg" alt="">
              <p>Experimentation with color and texture.</p>
            </a>
          </li>
          <li>
            <a href="img/numbers-02.jpg">
              <img src="img/numbers-02.jpg" alt="">
              <p>Playing with blending modes in Photoshop.</p>
            </a>
          </li>
        </ul>
      </section>
      <footer>
        <a href="http://twitter.com/nickrp"><img src="img/twitter-wrap.png" alt="Twitter Logo" class="social-icon"></a>
        <a href="http://facebook.com/nickpettit"><img src="img/facebook-wrap.png" alt="Facebook Logo" class="social-icon"></a>
        <p>&copy; 2016 Nick Pettit.</p>
      </footer>
    </div>
  <script src="js/app.js"></script>
  </body>
</html>

1 Answer

Brendan McCray
Brendan McCray
5,597 Points
Brendan McCray
Brendan McCray
5,597 Points

There's more than one way to select those <a> elements inside of the <nav> element. Here's one solution:

  • let navigationLinks = document.querySelectorAll('nav > ul > li > a');

This method selects all <a> elements that are children of <li>, which are children of <ul>, which are children of <nav>. It's not the most intuitive method, but it works.

Here's the answer to the next two steps:

  • let galleryLinks = document.querySelectorAll('ul#gallery > li > a');
  • let footerImages = document.querySelectorAll('footer > a > img');
Shardul Nandapurkar
Shardul Nandapurkar
969 Points
Shardul Nandapurkar
Shardul Nandapurkar
969 Points

Thanks for the explanation,this way of selection going through the code hierarchy was not talked about in the tutorial video so no way i could have known about it.