Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript and the DOM (Retiring) Getting a Handle on the DOM Selecting Multiple Elements

Leah Miller
Leah Miller
16,291 Points
Posted by Leah Miller
Leah Miller
16,291 Points

"Selecting Multiple Elements" I feel like my code is right...

I feel like my code is right for this challenge yet it keeps asking if I selected all 7 list items. In the preview window all the items are the color they should be. I've had problems before where my code was right and the site did not register. Please help.

js/app.js 
var listItems = rainbow;
var colors = ["#C2272D", "#F8931F", "#FFFF01", "#009245", "#0193D9", "#0C04ED", "#612F90"];

const rainbow = document.getElementsByTagName('li');

for(let i = 0; i < rainbow.length; i ++) {
  rainbow[i].style.color = colors[i];    
}
index.html 
<!DOCTYPE html>
<html>
  <head>
    <title>Rainbow!</title>
  </head>
  <body>
    <ul id="rainbow">
      <li>This should be red</li>
      <li>This should be orange</li>
      <li>This should be yellow</li>
      <li>This should be green</li>
      <li>This should be blue</li>
      <li>This should be indigo</li>
      <li>This should be violet</li>
    </ul>
    <script src="js/app.js"></script>
  </body>
</html>

4 Answers

Leah Miller
Leah Miller
16,291 Points
Leah Miller
Leah Miller
16,291 Points

Thanks, apparently it was looking for a specific way for it to be done.

passakorn chantarapakorn
passakorn chantarapakorn
2,472 Points

Thanks

Piotr Manczak
seal-mask
.a{fill-rule:evenodd;}techdegree seal-36
Piotr Manczak
Front End Web Development Techdegree Graduate 29,363 Points
Piotr Manczak
.a{fill-rule:evenodd;}techdegree seal-36
Piotr Manczak
Front End Web Development Techdegree Graduate 29,363 Points

var listItems = document.querySelectorAll('li');

var colors = ["#C2272D", "#F8931F", "#FFFF01", "#009245", "#0193D9", "#0C04ED", "#612F90"];

for(var i = 0; i < colors.length; i ++) {

listItems[i].style.color = colors[i];

}