Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript and the DOM (Retiring) Making Changes to the DOM Modifying Elements

Killeon Patterson
Killeon Patterson
18,528 Points
Posted by Killeon Patterson
Killeon Patterson
18,528 Points

Set the text content of the 'a' tag to be the value stored in the variable

I rewatched the video and I'm still lost?

index.html 
<!DOCTYPE html>
<html>
    <head>
        <title>DOM Manipulation</title>
    </head>
    <link rel="stylesheet" href="style.css" />
    <body>
        <div id="content">
            <label>Link Name:</label>
            <input type="text" id="linkName">
            <a id="link" href="https://teamtreehouse.com"></a>
        </div>
        <script src="app.js"></script>
    </body>
</html>
app.js 
let linkName = document.getElementById('linkName').value; 
a.innerHTML = linkName.value;

2 Answers

ve
ve
5,048 Points

First, you can't just say "a.innerHTML", your browser will say that "a" is undefined. You have to select that element first, I'd use the ID given.

Then you don't need to use .value on an attribute, you already access that value by just writing down its name:

document.getElementById("link").innerHTML = linkName;
Abraham Juliot
Abraham Juliot
47,353 Points
Abraham Juliot
Abraham Juliot
47,353 Points 
// this works

a = document.getElementById('link'),
value = document.getElementById('linkName').value; 
a.innerHTML = value; 

// this shorter syntax also works, just for fun
let 
doc = document,
$  = {
  "id": "getElementById", 
  "val": "value",
  "html": "innerHTML"
},
a = doc[$.id]('link'),
value = doc[$.id]('linkName')[$.val]; 

a[$.html] = value;