Setter method quiz

Question

WOndering why this is not working
get major(){
  return this.major;
  }
  set major(major){
    this._major=major
    if (this.credits > 90 ) {
            return 'Senior';
        } else if (this.credits > 60) {
            return 'Junior';
        } else if (this.credits > 30) {
            return 'Sophomore';
        } else {
            return 'Freshman';
        }
       }
}
```creating_setters.js
class Student {
    constructor(gpa, credits){
        this.gpa = gpa;
        this.credits = credits;
    }
stringGPA() {
    return this.gpa.toString();
}

get level() {
    if (this.credits > 90 ) {
        return 'Senior';
    } else if (this.credits > 60) {
        return 'Junior';
    } else if (this.credits > 30) {
        return 'Sophomore';
    } else {
        return 'Freshman';
    }
}
  get major(){
  return this.major;
  }
  set major(major){
    this._major=major
    if (this.credits > 90 ) {
            return 'Senior';
        } else if (this.credits > 60) {
            return 'Junior';
        } else if (this.credits > 30) {
            return 'Sophomore';
        } else {
            return 'Freshman';
        }
       }
}
var student = new Student(3.9, 60);
```

Steven Parker · Answer

It looks like you copied the code from the "level" getter method.  It does something entirely different from what a setter method would do.
The backing property should only be set to the parameter if the level is either "Junior" or "Senior".  Otherwise it should be set to the string "None".
Also:
- the instructions don't ask for a "major" getter method
- setters don't need to return a value

Welcome to the Treehouse Community

Looking to learn something new?

Joel Rothstein

Joel Rothstein

Setter method quiz

1 Answer

Steven Parker

Steven Parker