Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript Basics (Retired) Creating Reusable Code with Functions Create a max() Function

Posted by Unsubscribed User
Unsubscribed User
3,436 Points

Solving Functions JavaScript Challenge

Here is the question: Create a new function named max which accepts two numbers as arguments (you can name the arguments, whatever you would like). The function should return the larger of the two numbers.

HINT: You'll need to use a conditional statement to test the 2 parameters to see which is the larger of the two.

Here is my solution

function max (7,4) {
  var biggerNumber = Math.max(7,4);
  return biggerNumber;
}

I can't figure what I did wrong. Can you point me to the right direction?

script.js 
function max (7,4) {
  var biggerNumber = Math.max(7,4);
  return biggerNumber;
}

3 Answers

Steven Parker
Steven Parker
231,236 Points
Steven Parker
Steven Parker
231,236 Points

You need names for your arguments.

When you define a function, you provide names to serve as placeholders for the actual arguments that will be used when the function is called. later. The names can be any legal variable names (but not numbers).

So instead of:

function max (7,4) {

You might write:

function max(first, second) {

Also, it might pass, but it's "cheating" to call the built-in max function. :open_mouth: I think you're supposed to create your own without calling any external functions.

Unsubscribed User
Unsubscribed User
3,436 Points
Unsubscribed User
Unsubscribed User
3,436 Points

Solved it. Thanks!

Ryan Rankin
Ryan Rankin
8,261 Points
Ryan Rankin
Ryan Rankin
8,261 Points

So in this challenge you're asked to pass two numbers as arguments. The numbers will be determined later outside of the function when called. This way at a later time you can apply 2 different numbers to compare instead of your way where you will always be comparing 4 and 7. Also in order to compare the arguments the challenge is asking you to use a conditional statement.

This is my solution...

function max (num1, num2) {
  if (num1 > num2) {
    return num1;
  } else {
    return num2
  }
}

max(5,7);