Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python Python Collections (2016, retired 2019) Dictionaries String Formatting with Dictionaries

sandeep krishnappa
sandeep krishnappa
1,571 Points
Posted by sandeep krishnappa
sandeep krishnappa
1,571 Points

String_factory exercise keep giving invalid syntax for return new_list

The check kept giving me the same invalid syntax error on return new_list at the end of the code. Not sure what is the problem here.

string_factory.py 
# Example:
# values = [{"name": "Michelangelo", "food": "PIZZA"}, {"name": "Garfield", "food": "lasagna"}]
# string_factory(values)
# ["Hi, I'm Michelangelo and I love to eat PIZZA!", "Hi, I'm Garfield and I love to eat lasagna!"]



def string_factory(values):
    values = [{'name': 'Michelangelo', 'food': 'PIZZA'}, {'name': 'Garfield', 'food': 'lasagna'}]
    template = "Hi, I'm {name} and I love to eat {food}!"
    new_list = []
    for words in values:
        new_list.append(template.format(**words)
    return new_list

1 Answer

Stuart Wright
Stuart Wright
41,120 Points
Stuart Wright
Stuart Wright
41,120 Points

The syntax error is in your second last line - you've missed a closing bracket:

new_list.append(template.format(**words))

Your code still won't pass the challenge however. You need to delete the line which defines values inside the function:

values = [{'name': 'Michelangelo', 'food': 'PIZZA'}, {'name': 'Garfield', 'food': 'lasagna'}]

This is because the function should accept a list of dictionaries from the user, rather than define its own values inside the function.

With these two fixes, your code should pass the challenge.

sandeep krishnappa
sandeep krishnappa
1,571 Points
sandeep krishnappa
sandeep krishnappa
1,571 Points

Thank you very much Stuart. The revised code passed the challenge.