Welcome to the Treehouse Community
Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.
Looking to learn something new?
Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.
Start your free trialSean Banko
6,558 PointsStruggling with Hand.roll(2), seems to be working in Workspaces
Not sure why this is failing to pass the code challenge. Current error message is "Can't get the length of "Hand".... any advice?
Also, in general, what would be the "best" (or maybe "most Pythonic"? – really I just mean most efficient) way of accomplishing this code challenge? That is, what would really clean code look like for this? I'm still not sure I totally understand class methods and properties and I feel as though even if my code worked it might still be redundant or otherwise cluttered.
import random
class Die:
def __init__(self, sides=2):
if sides < 2:
raise ValueError("Can't have fewer than two sides")
self.sides = sides
self.value = random.randint(1, sides)
def __int__(self):
return self.value
def __add__(self, other):
return int(self) + other
def __radd__(self, other):
return self + other
class D20(Die):
def __init__(self):
super().__init__(sides = 20)
from dice import D20
class Hand(list):
def __init__(self, size = 0, die_class = None):
super().__init__()
for _ in range(size):
self.append(die_class())
self.sort()
@classmethod
def roll(cls, size = 0, die_class = D20):
return cls(size, die_class)
@property
def total(self):
return sum(self)
1 Answer
Steven Parker
231,275 PointsThe instructions don't say anything about sorting the list.
Sean Banko
6,558 PointsSean Banko
6,558 PointsThat did it. Thanks!