Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

PHP Build a Basic PHP Website (2018) Enhancing a Form Escaping Output

Andrew Norris
Andrew Norris
4,857 Points
Posted by Andrew Norris
Andrew Norris
4,857 Points

Stuck on code challenge in build a basic php website enhancing a form escaping output

I escaped output on all the form fields. I don't understand why the code challenge says I still need to escape the "name" variable.

views_listing_edit.php 
<?php require_once("controllers_listing.php"); ?><html>
<body>

    <h1>Edit Listing</h1>

    <form method="post">
        <table>
            <tr>
                <th>
                    <label for="name">Name</label>
                </th>
                <td>
                    <input id="name" name="name" value="<?php if (isset($listing_name)) echo htmlspecialchars($_POST["listing_name"]);?>">
                </td>
            </tr>
            <tr>
                <th>
                    <label for="Link">Link</label>
                </th>
                <td>
                    <input id="link" name="link" value="<?php  if (isset($listing_link)) echo htmlspecialchars($_POST["listing_link"]); ?>">
                </td>
            </tr>
            <tr>
                <th>
                    <label for="Description">Description</label>
                </th>
                <td>
                    <textarea id="description" name="description"><?php if (isset($listing_description)) echo htmlspecialchars($_POST["listing_description"]); ?></textarea>
                </td>
            </tr>    
        </table>
        <input type="submit" value="Save">
    </form>

</body>
</html>

1 Answer

jcorum
jcorum
71,830 Points

The editor is looking for one way of doing this:

<?php require_once("controllers_listing.php"); ?><html>
<body>

    <h1>Edit Listing</h1>

  <form method="post">
        <table>
            <tr>
                <th>
                    <label for="name">Name</label>
                </th>
                <td>
                   <input id="name" name="name" value="<?php echo htmlspecialchars($listing_name);?>">
                </td>
            </tr>
            <tr>
                <th>
                    <label for="Link">Link</label>
                </th>
                <td>
                    <input id="link" name="link" value="<?php echo htmlspecialchars($listing_link); ?>">
                </td>
            </tr>
            <tr>
                <th>
                    <label for="Description">Description</label>
                </th>
                <td>
                   <textarea id="description" name="description">)<?php echo htmlspecialchars($listing_description); ?></textarea>
                </td>
            </tr>    
        </table>
        <input type="submit" value="Save">
    </form>

</body>
</html>

In short, you did more work than they wanted. Not that there's anything really wrong with your work. And the error message is totally spurious.

Andrew Norris
Andrew Norris
4,857 Points
Andrew Norris
Andrew Norris
4,857 Points

Thanks for the help and the vindication. I should know by now to keep it simple.