Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript and the DOM (Retiring) Making Changes to the DOM Styling Elements

lionelsurmont
lionelsurmont
7,092 Points
Posted by lionelsurmont
lionelsurmont
7,092 Points

The list hides but doesn't show back again

I don't understand the error in my code. The list hides as intended when clicking on the toggleList button, but it doesn't show back when clicking a second time.

const toggleList = document.querySelector('#toggleList');
const list = document.querySelector('.list');
const input = document.querySelector('input.description');
const p = document.querySelector('p.description');
const button = document.querySelector('button.description');

toggleList.addEventListener('click', () => {
    if (list.display == "none") {
        toggleList.textContent = 'Hide list';
        list.style.display = "block";
    } else {
        toggleList.textContent = 'Show list';
        list.style.display = "none";
    }
});

button.addEventListener('click', () => {
  p.innerHTML = input.value + ':';
});

<!DOCTYPE html>
<html>
  <head>
    <title>JavaScript and the DOM</title>
    <link rel="stylesheet" href="css/style.css">
  </head>
  <body>
    <h1 id="myHeading">JavaScript and the DOM</h1>
    <p>Making a web page interactive</p>
    <button id="toggleList">Hide list</button>
    <div class="list">
        <p class="description">Things that are purple:</p>
        <input type="text" class="description">
        <button class="description">Change list description</button>
        <ul>
            <li>grapes</li>
            <li>amethyst</li>
            <li>lavender</li>
            <li>plums</li>
        </ul>
    </div>
    <script src="app.js"></script>
  </body>
</html>

1 Answer

Gustavo Winter
PLUS
Gustavo Winter
Courses Plus Student 27,382 Points
Gustavo Winter
Gustavo Winter
Courses Plus Student 27,382 Points

Hi, you made a common mistake.

In your if statement you use

if (list.display == "none")

You just need to add the style property. I'll fix your problem.

Always check the part that works with what does not work, almost always finds useful information.

if (list.style.display == "none")
Jason Anello
Jason Anello
Courses Plus Student 94,610 Points

changed comment to answer