Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript Loops, Arrays and Objects Simplify Repetitive Tasks with Loops The Refactor Challenge

Hunter Shaw
Hunter Shaw
2,187 Points
Posted by Hunter Shaw
Hunter Shaw
2,187 Points

This is correct? Tips and suggestions are appreciated. Thanks!

var html = '';
var red;
var green;
var blue;
var rgbColor;

function randomColors(html) {
  red = Math.floor(Math.random() * 256 );
  green = Math.floor(Math.random() * 256 );
  blue = Math.floor(Math.random() * 256 );
  rgbColor = 'rgb(' + red + ',' + green + ',' + blue + ')';
  return html += '<div style="background-color:' + rgbColor + '"></div>';
}


for ( i = 0; i < 10; i += 1) {
  document.write(randomColors(html));
}

1 Answer

Leandro Botella Penalva
Leandro Botella Penalva
17,618 Points
Leandro Botella Penalva
Leandro Botella Penalva
17,618 Points

Hi Hunter,

You code works fine but could be improved.

First, since you are using the variables red, green, blue, rgbColor inside the function only you could declare them inside the function instead so they are not in the global scope. Also, you don't need to pass the html variable each time to the function you could simply return the div and print it out right away.

What I said above would result in:

function randomColors() {
    var red = Math.floor(Math.random() * 256 );
    var green = Math.floor(Math.random() * 256 );
    var blue = Math.floor(Math.random() * 256 );
    var rgbColor = 'rgb(' + red + ',' + green + ',' + blue + ')';
    return '<div style="background-color:' + rgbColor + '"></div>';
}

for ( i = 0; i < 10; i += 1) {
    document.write(randomColors());
}

The following videos Dave tells some ways to make it more modular. The code above could be splitted in some more functions.

Hope it helps.