Trying to practice what i learned

Question

Hello there, 
Bellow is my solution but i added a bit to it, my goal was not to have a negative number in case the first input is higher that the second, please let me know what u think
`
function randomNumber (num1, num2) {
  if (num1 > num2){
   const upper = Math.floor(Math.random() * (num1 - num2 + 1)) + 1; 
    return ${upper} , Is a randome number between ${num1} and ${num2};
  }else {
   const down = Math.floor(Math.random() * (num2 - num1 + 1)) + 1;  
    return ${down} , Is a randome number between ${num1} and ${num2};
  } 
}
console.log(randomNumber(20, 50));
`

seth aruby · Accepted Answer

Ahmed,
Almost there, but you're missing a couple things.  Remember the Math.random() function returns any number between 0 and 1, but not including 1.  So this means that it could return '0'.  Given this you must make sure that when trying to generate a random number between 2 numbers, a min and a max, that your random number generator code appropriately considers this, so that if num2 is your min number and if Math.random() does return 0 then your random number generator code will return num2, and vice versa if num1 is your min number.  Also your template literal expressions are incomplete as they are missing the 'backticks', like the following:
javascript
if (num1 > num2){ 
const upper = Math.floor(Math.random() * (num1 - num2 + 1)) + num2; 
return `${upper} , Is a randome number between ${num2} and ${num1}`; 
} 
else { 
const down = Math.floor(Math.random() * (num2 - num1 + 1)) + num1;
return `${down} , Is a randome number between ${num1} and ${num2}`; 
};

Welcome to the Treehouse Community

Looking to learn something new?

Ahmed El-Kordy

Ahmed El-Kordy

Trying to practice what i learned

1 Answer

seth aruby

seth aruby