Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript and the DOM (Retiring) Getting a Handle on the DOM Selecting Multiple Elements

Posted by blueskyispink
blueskyispink
2,997 Points

TypeError on retrieving a list item from querySelectorAll.

Hey all!

I am not sure what is going on, but I get a TypeError on listItems[i]. I can't really understand what is the issue via the console as it covers the whole page. Can someone please advise on what is the issue with the code? I played around with querySelectorAll and it should just give a list, but it does not in the console...

js/app.js 
const listItems = document.querySelectorAll('#rainbow');
var colors = ["#C2272D", "#F8931F", "#FFFF01", "#009245", "#0193D9", "#0C04ED", "#612F90"];

for(var i = 0; i < colors.length; i ++) {
  listItems[i].style.color = colors[i];    
}
index.html 
<!DOCTYPE html>
<html>
  <head>
    <title>Rainbow!</title>
  </head>
  <body>
    <ul id="rainbow">
      <li>This should be red</li>
      <li>This should be orange</li>
      <li>This should be yellow</li>
      <li>This should be green</li>
      <li>This should be blue</li>
      <li>This should be indigo</li>
      <li>This should be violet</li>
    </ul>
    <script src="js/app.js"></script>
  </body>
</html>
blueskyispink
blueskyispink
2,997 Points

Note: this is from the code challenge. It wasn't written in the workspace.

1 Answer

Milan Toth
Milan Toth
12,182 Points
Milan Toth
Milan Toth
12,182 Points

Try : document.querySelectorAll('#rainbow li'); You currently only selecting the ul not the list items.