Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

PHP Enhancing a Simple PHP Application Refactoring the Codebase Separating Concerns: Models

Iain Petrie
Iain Petrie
11,149 Points
Posted by Iain Petrie
Iain Petrie
11,149 Points

What have I done wrong?

Need a hint, I can't see what I'm missing?

index.php 
<?php

// ==== INCLUDE MODEL FILE ====
require_once('flavors.php');

$flavors = get_all_flavors();

<h1>Ye Olde Ice Cream Shoppe</h1>

<p>Here&rsquo;s a full list of our ice cream flavors.</p>

<ul>
<?php

    $list_html = "";
    foreach($flavors as $flavor) {
        $list_html = $list_html . "<li>";
        $list_html = $list_html . $flavor;
        $list_html = $list_html . "</li>";
    }
    echo $list_html;

?>
</ul>
flavors.php 
<?php

// MODEL FILE
function get_all_flavors() {
  $flavors = array(
        "Jalapeno So Spicy",
        "Avocado Chocolate",
        "Peppermint",
        "Vanilla",
        "Cake Batter",
        "Cookie Dough"
    );
  return $flavors;


}





?>

1 Answer

Brandon Berger
Brandon Berger
3,947 Points
Brandon Berger
Brandon Berger
3,947 Points 
<?php

// ==== INCLUDE MODEL FILE ====
require_once('flavors.php');

$flavors = get_all_flavors();

#CLOSE PHP TAG
?>

<h1>Ye Olde Ice Cream Shoppe</h1>

<p>Here&rsquo;s a full list of our ice cream flavors.</p>



<ul>

<?php

    $list_html = "";
    foreach($flavors as $flavor) {
        $list_html = $list_html . "<li>";
        $list_html = $list_html . $flavor;
        $list_html = $list_html . "</li>";
    }
    echo $list_html;

?>
</ul>
Iain Petrie
Iain Petrie
11,149 Points
Iain Petrie
Iain Petrie
11,149 Points

Thanks. I had gone back and done it before your answer came in and got it first time. Sometimes you can't see it for looking at it!