Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Ruby Ruby Operators and Control Structures Logical Operators The Or (||) Operator

Posted by Will Long
Will Long
5,449 Points

What is wrong with my program

def valid_command?(command) command = gets.chomp if (valid_command? == "y") || (valid_command? == "yes") || (valid_command? == "Y") || (valid_command? == "YES") valid_command? = true end

ruby.rb 
def valid_command?(command)
    command = gets.chomp
if (valid_command? == "y") || (valid_command? == "yes") || (valid_command? == "Y") || (valid_command? == "YES")
    valid_command? = true
end

3 Answers

Salman Akram
Salman Akram
Courses Plus Student 40,065 Points

Hi Will,

You need to remove brackets ( ) in each command and fix if statements to use command, not valid_command and then finally return true.

Good example here: 

def valid_command?(command)

  if command == "y" || command == "yes" || command == "Y" || command == "YES"
    return "true"
  end

end
Derek Hill
Derek Hill
3,726 Points
Derek Hill
Derek Hill
3,726 Points

Actually, you have 3 mistakes in your code.

  1. For the check, you should be checking "command" and not "valid_command?" as that is the name of your function.

  2. You are missing an end statement, you only have one, but you need to have one for the def and one for the if statements.

  3. You are not returning anything

Caleb Kleveter
MOD
Caleb Kleveter
Treehouse Moderator 37,862 Points
Caleb Kleveter
Caleb Kleveter
Treehouse Moderator 37,862 Points

You forgot to print a string.

print "-----"

fill in the blank with whatever you want.