Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python Python Collections (Retired) Dictionaries Membership

Posted by MUZ140515 Herbert Chirwa
MUZ140515 Herbert Chirwa
2,589 Points

whats wrong with this code

stuck don't know were l,m getting it wrong

counts.py 
# You can check for dictionary membership using the
# "key in dict" syntax from lists.

### Example
# my_dict = {'apples': 1, 'bananas': 2, 'coconuts': 3}
# my_list = ['apples', 'coconuts', 'grapes', 'strawberries']
# members(my_dict, my_list) => 2
def members(my_dict, my_list):
    for item in my_list:
      if item in my_dict:
        my_dict[item] += 1
      else:
        my_dict[item] = 1   
    return my_dict

1 Answer

Erick Kusnadi
Erick Kusnadi
21,615 Points
Erick Kusnadi
Erick Kusnadi
21,615 Points

The code should be retuning a single number, but it returns the entire dictionary. It looks like the code is adding to the dictionary, but the code should instead count the number of items in the list, that is also in the dictionary.

def members(my_dict, my_list):
    count = 0
    for item in my_list:
      if item in my_dict:
        count += 1  
    return count
MUZ140515 Herbert Chirwa
MUZ140515 Herbert Chirwa
2,589 Points

thanx man realised my mistake