Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript Basics (Retired) Storing and Tracking Information with Variables Using String Methods

sai krishna
sai krishna
4,314 Points
Posted by sai krishna
sai krishna
4,314 Points

When I finish task 2 it says task 1 is no longer passing.

my code: var id = "23188xtr"; var lastName = "Smith;

var userName = id; task1: var userName = id.toUpperCase(); /convert id variable to uppercase and assign it to userName/

task2: var userName = id.toUpperCase(); userName += userName +"#" +lastName.toUpperCase();

/* The final value of UserName should be '23188XTR#SMITH '*/

app.js 
var id = "23188xtr".toUpperCase;
var lastName = "Smith";

var userName;
userName = id +"#";
userName += userName + lastName.toUpperCase();
index.html 
<!DOCTYPE HTML>
<html>
<head>
  <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  <title>JavaScript Basics</title>
</head>
<body>
<script src="app.js"></script>
</body>
</html>

1 Answer

Redweb FED
Redweb FED
15,517 Points
Redweb FED
Redweb FED
15,517 Points

Your var id is missing "()" after toUpperCase.

sai krishna
sai krishna
4,314 Points
sai krishna
sai krishna
4,314 Points

I actually put the right code...I added the (), it still doesn't work.

Redweb FED
Redweb FED
15,517 Points

Oh I see it now. 

userName += userName + lastName.toUpperCase();

is the same as saying 

"23188XTR#23188XTR#SMITH"

This is because your concatenating userName when "23188xtr".toUpperCase(); twice is the final value. += means add to what is already stored in the variable.

change it to whats below and that shoul fix it.

userName += lastName.toUpperCase();