Welcome to the Treehouse Community
Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.
Looking to learn something new?
Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.
Start your free trialChristian Lamoureux
Full Stack JavaScript Techdegree Student 22,669 PointsWhen I run my code in python it never gives false positives...
I also tried the simpler def doubles(self): return self[0] == self[1]
had similar results where it says got true for a non-pair
from dice import D6
class Hand(list):
def __init__(self, size=0, die_class=None, *args, **kwargs):
if not die_class:
raise ValueError("You must provide a die class")
super().__init__()
for _ in range(size):
self.append(die_class())
self.sort()
def _by_value(self, value):
dice = []
for die in self:
if die == value:
dice.append(die)
return dice
class CapitalismHand(Hand):
def __init__(self, *args, **kwargs):
super().__init__(size = 2, die_class = D6)
def doubles(self):
if self[0] == self[1]:
return True
else:
return False
@property
def ones(self):
return self._by_value(1)
@property
def twos(self):
return self._by_value(2)
@property
def threes(self):
return self._by_value(3)
@property
def fours(self):
return self._by_value(4)
@property
def fives(self):
return self._by_value(5)
@property
def sixes(self):
return self._by_value(6)
@property
def _sets(self):
return {
1: len(self.ones),
2: len(self.twos),
3: len(self.threes),
4: len(self.fours),
5: len(self.fives),
6: len(self.sixes)
}
2 Answers
Steven Parker
231,275 PointsI'm not sure what you mean by "false positives" but at first glance I notice that you have changed the design of "Hand" so that a "die_class" argument is required to create an instance.
But in the challenge, "Hand" originally did not require any argument to create a new instance, and the instructions did not say that should be changed. So when the challenge validates your code, and it tries to create a new "Hand" instance without providing any arguments, that operation will fail and thus the validation does not pass.
Christian Lamoureux
Full Stack JavaScript Techdegree Student 22,669 PointsI did find those changes and fixed them, ultimately found what I was missing was that the challenge wanted the method to be a class method. Thank you