Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript Basics (Retired) Creating Reusable Code with Functions Create a max() Function

Why does it say I haven't made a function named max() when I have?

I'm just wondering why it says i haven't made a function named max() when I have

script.js
function max(number1, number2) {
  if (number1 > number2) {
   return max();
  } else {
   return max(); 
  }
}

I'm new to JavaScript and i'm enjoying it I have been fine up to this point but i'm now stuck

1 Answer

Hi Joshua,

you are calling your function inside of its declaration. What you are supposed to do is define the function first (you can call it later outside of its declaration). The challenge requires the function to return the greater of two numbers, so your code for Task 1 should look something like this:

function max(number1, number2) {
  if (number1 > number2) {
   return number1;
  } else {
   return number2; 
  }
}

And to call your function later (just an example):

max(274, 256);

Hope this helps!

Thanks that did help, now my code works and thanks for the advice i'll know for the future now.