Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript Loops Working with 'for' Loops The Refactor Challenge – One Solution

Posted by dave li
dave li
723 Points

Why does my color stay the same throughout the loop ?

let html = ''; let red = Math.floor(Math.random() * 256); let green = Math.floor(Math.random() * 256); let blue = Math.floor(Math.random() * 256); let randomRGB = rgb( ${red}, ${green}, ${blue});

console.log(red) console.log(green) console.log(blue)

for(let i = 0; i <= 10; i++){

html += <div style="background-color: ${randomRGB}">${i}</div>; }

document.querySelector('main').innerHTML = html;

How will I refactor this code so that I get a random RGB for each loop ?

1 Answer

Joseph Yhu
seal-mask
.a{fill-rule:evenodd;}techdegree seal-36
Joseph Yhu
PHP Development Techdegree Graduate 48,638 Points
Joseph Yhu
.a{fill-rule:evenodd;}techdegree seal-36
Joseph Yhu
PHP Development Techdegree Graduate 48,638 Points

It's because the code that generates random colors is outside the for loop, which means it will generate only a single random color. You have to put the code inside, like this:

for (let i = 0; i <= 10; i++) {
    red = Math.floor(Math.random() * 256);
    green = Math.floor(Math.random() * 256);
    blue = Math.floor(Math.random() * 256);
    randomRGB = `rgb( ${red}, ${green}, ${blue} )`;
    html += `<div style="background-color: ${randomRGB}">${i}</div>`;
}