why doesn't my code work?

Question

Create a function named nchoices() that takes an iterable and an integer. The function should return a list of nrandom items from the iterable where n is the integer. Duplicates are allowed.
my code:
```python
def nchoices(iterable, n):
  n_list = []
  number = int(n)
  # get the random item from the list
put n random items in the list
while number > 0:
  randomitem = random.choice(iterable)
  nlist.append(random_item)
  number -=1
return the list
return n_list
```

Jeff Morrison · Accepted Answer

What output are you getting, which you weren't expecting?
From looking at your code:
1. You need to import random in order to use it (which maybe you did and didn't copy and paste)
2. Your while and return should be indented - otherwise they're not part of the function
3. Instead of a while loop and decrementing (count n down) - I would use the range() function, which does the work for you. This is built in to do loop management for you.
```python
import random
def nchoices(iterable, n):
    nlist = []
    for _ in range(n):
        ##do the choosing and appending here
    return nlist
```

AR Ehsan · Answer

Here how I did it
python
import random
def nchoices(iterable, count):
    lst = []
    for x in range(count):
        lst.append(random.choice(iterable))
    return lst

Welcome to the Treehouse Community

Looking to learn something new?

neilatoofuny

neilatoofuny

why doesn't my code work?

2 Answers

Jeff Morrison

Jeff Morrison

AR Ehsan

AR Ehsan