Why Hand.roll() is not correct?

Question

I followed the steps for this exercise. When I do like in the example and call Hand.roll(2), I do get two dice with a value up to 20. However, the exercise doesn't accept my code as valid. What I'm doing wrong?

dice.py

import random


class Die:
    def __init__(self, sides=2):
        if sides < 2:
            raise ValueError("Can't have fewer than two sides")
        self.sides = sides
        self.value = random.randint(1, sides)

    def __int__(self):
        return self.value

    def __add__(self, other):
        return int(self) + other

    def __radd__(self, other):
        return self + other


class D20(Die):
    def __init__(self):
        super().__init__(sides=20)

hands.py

from dice import D20


class Hand(list):
    @property
    def total(self):
        return sum(self)

    @classmethod
    def roll(cls, number_dice):
        hand_roll = cls()
        for _ in range(number_dice):
            hand_roll.append(int(D20()))
        return hand_roll

Answer 1 · 2022-06-09T13:05:16Z

June 9, 2022 1:05pm

You're really close! But the challenge wants your method to return a list containing the actual D20 objects and not just their values. So leave off the "int" conversion.

Answer 2 · 2022-06-09T13:16:45Z

June 9, 2022 1:16pm

Of course!! Thank you for your help.

Welcome to the Treehouse Community

Looking to learn something new?

Roger Perelló

Roger Perelló

Why Hand.roll() is not correct?

2 Answers

Steven Parker

Steven Parker

Roger Perelló

Roger Perelló