Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript and the DOM (Retiring) Making Changes to the DOM Modifying Elements

tal Shnitzer
PLUS
tal Shnitzer
Courses Plus Student 5,242 Points
Posted by tal Shnitzer
tal Shnitzer
Courses Plus Student 5,242 Points

why is my code not ok?

the innerValue should get the text content of the a tag.

app.js 
let input = document.querySelector('input');
let inputValue = input.value;
let a = document.querySelector('a');
inputValue = a.textContent;
index.html 
<!DOCTYPE html>
<html>
    <head>
        <title>DOM Manipulation</title>
    </head>
    <link rel="stylesheet" href="style.css" />
    <body>
        <div id="content">
            <label>Link Name:</label>
            <input type="text" id="linkName">
            <a id="link" href="https://teamtreehouse.com"></a>
        </div>
        <script src="app.js"></script>
    </body>
</html>

2 Answers

behar
behar
10,799 Points

Hey tal! The issue lies with the way your sellecting textContent. It should be:

(theElementYouWantToSellect).textContent = (whatYouWantToChangeItTo) // Ingnore the parenthesis

But you could also shorten your code quite abit. Look at the following example:

let inputValue = document.getElementById("linkName").value;
document.getElementById("link").textContent = inputValue;
tal Shnitzer
tal Shnitzer
Courses Plus Student 5,242 Points
tal Shnitzer
tal Shnitzer
Courses Plus Student 5,242 Points

that's worked so thanks. I wish that the definition of the task was clearer. I thought that *** I should get the text content of the 'a' tag and assign it to the variable inputValue.*** lets say that was the assignment, was my code correct?

behar
behar
10,799 Points

Hey again tal! Yes if that was the goal of the challenge your code would be totally valid. You can mark the question as solved if you feel this answered your question.

behar
behar
10,799 Points

Glad to help! You can mark the question as "solved" by sellecting a "best answer".