Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

PHP Object-Oriented PHP Basics (Retired) Inheritance, Interfaces, and Exceptions Final Challenge

Michael Randolph
Michael Randolph
11,497 Points
Posted by Michael Randolph
Michael Randolph
11,497 Points

Why is my getInfo method not working?

I don't understand why my getInfo method is not working in this final challenge. I have reviewed the video but I am lost. Any help is greatly appreciated.

fish.php 
<?php

class Fish
{
    public $common_name;
    public $flavor;
    public $record_weight;

    function __construct($name, $flavor, $record){
        $this->common_name = $name;
        $this->flavor = $flavor;
        $this->record_weight = $record;
    }

    public function getInfo() {
        $output  = "The {$this->common_name} is an awesome fish. ";
        $output .= "It is very {$this->flavor} when eaten. ";
        $output .= "Currently the world record {$this->common_name} weighed {$this->record_weight}.";
        return $output;
    }
}

class Trout extends Fish {

  public $species; 

  function __construct($name, $flavor, $record, $species){
    parent::__construct($name, $flavor, $record);
    $this->species = $species;

  }

    public function getInfo() {
        return "$this->species $this->name tastes ". $this->flavor.  The record ". $this->species $this->name ." weighed ". $this->record.";
  }

$brook_trout = new Trout ("Trout", "Delicious", "14 pounds 8 ounces", "Brook");
echo $brook_trout->getInfo();
?>

2 Answers

Emiliano Ceccon
Emiliano Ceccon
931 Points
Emiliano Ceccon
Emiliano Ceccon
931 Points

Hi!

Your code has several errors, we look them one by one:

line 34: Some variables are wrong concatenated, as their names, remember that the name ($common_name), taste ($flavor), and record weight ($record_weight) are properties that belong to the parent class, the only property that is part of the class Trout is the species ($species), the return should look like:

<?php
    return $this->species . " " . $this->common_name . " tastes " . $this->flavor . ". " . "The record " . $this->species . " " . $this->common_name . " weighed " . $this->record_weight . ".";
?>

You can write it concatenating this way too:

<?php
    return "{$this->species} {$this->common_name} tastes {$this->flavor}. The record {$this->species} {$this->common_name} weighed {$this->record_weight}.";
?>

line 36: You forgot the closing curly brace ("}") that indicates the end of the class.

Your corrected code should look like this:

<?php

class Fish
{
    public $common_name;
    public $flavor;
    public $record_weight;

    function __construct($name, $flavor, $record){
        $this->common_name = $name;
        $this->flavor = $flavor;
        $this->record_weight = $record;
    }

    public function getInfo() {
        $output  = "The {$this->common_name} is an awesome fish. ";
        $output .= "It is very {$this->flavor} when eaten. ";
        $output .= "Currently the world record {$this->common_name} weighed {$this->record_weight}.";

        return $output;
    }
}

class Trout extends Fish {

    public $species; 

    function __construct($name, $flavor, $record, $species){
        parent::__construct($name, $flavor, $record);

        $this->species = $species;
    }

    public function getInfo() {
        return $this->species . " " . $this->common_name . " tastes " . $this->flavor . ". " . "The record " . $this->species . " " . $this->common_name . " weighed " . $this->record_weight . ".";
    }
}

$brook_trout = new Trout("Trout", "Delicious", "14 pounds 8 ounces", "Brook");

echo $brook_trout->getInfo();

?>

You can get more information about strings in PHP: Strings.

I hope I've helpful to you!

Michael Randolph
Michael Randolph
11,497 Points
Michael Randolph
Michael Randolph
11,497 Points

Thank you! This was very helpful.