Welcome to the Treehouse Community
Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.
Looking to learn something new?
Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.
Start your free trialshekhar bhardwaj
Full Stack JavaScript Techdegree Student 12,373 PointsWorking fine in my ide, please if you can tell me what is wrong here in double function.
I have tested my function in my local
for _ in range(100):
ct = CapitalismHand()
print(ct)
print(ct.doubles)
and it is working as expected, please need help.
from dice import D6
class Hand(list):
def __init__(self, size=0, die_class=None, *args, **kwargs):
if not die_class:
raise ValueError("You must provide a die class")
super().__init__()
for _ in range(size):
self.append(die_class())
self.sort()
def _by_value(self, value):
dice = []
for die in self:
if die == value:
dice.append(die)
return dice
class CapitalismHand(Hand):
def __init__(self):
super().__init__(size=2, die_class=D6)
@property
def ones(self):
return self._by_value(1)
@property
def twos(self):
return self._by_value(2)
@property
def threes(self):
return self._by_value(3)
@property
def fours(self):
return self._by_value(4)
@property
def fives(self):
return self._by_value(5)
@property
def sixes(self):
return self._by_value(6)
@property
def doubles(self):
all_values = [
self.ones,
self.twos,
self.threes,
self.fours,
self.fives,
self.sixes
]
is_double = False
for value in all_values:
if len(value) == 2:
is_double = True
return is_double
@property
def _sets(self):
return {
1: len(self.ones),
2: len(self.twos),
3: len(self.threes),
4: len(self.fours),
5: len(self.fives),
6: len(self.sixes)
}
1 Answer
shekhar bhardwaj
Full Stack JavaScript Techdegree Student 12,373 PointsFound the issue, return was not properly indented.
is_double = False
for value in all_values:
if len(value) == 2:
is_double = True
return is_double
Chris Freeman
Treehouse Moderator 68,457 PointsChris Freeman
Treehouse Moderator 68,457 PointsSince this class is a subset of
list
you can do a simple check ofself[0].value == self[1].value
to determine "doubles". Or, this can be shorted further toself[0] == self[1]
.