Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript Object-Oriented JavaScript Getters and Setters Creating Setter Methods

Leah Miller
Leah Miller
16,291 Points
Posted by Leah Miller
Leah Miller
16,291 Points

A different take, same problem

I am having some difficulties with this code. In doing some looking in the community it seems others took a different approach to the "set major" To me this seems like it should work. 2 questions. 1. Can this approach to the code work? 2. What am I doing wrong?

Thanks!

creating_setters.js 
class Student {
    constructor(gpa, credits){
        this.gpa = gpa;
        this.credits = credits;
    }

    stringGPA() {
        return this.gpa.toString();
    }

    set major(major) {
      this._major = major;
      if (this.credits > 60) {
        return major;   
      } else {
        return 'none';
      }
    }

    get major () {
      return this._major;
    }

    get level() {
        if (this.credits > 90 ) {
            return 'Senior';
        } else if (this.credits > 60) {
            return 'Junior';
        } else if (this.credits > 30) {
            return 'Sophomore';
        } else {
            return 'Freshman';
        }
    }
}

var student = new Student(3.9, 60);

2 Answers

scribbles
scribbles
21,173 Points

The major setter method should be setting the student's major to the desired value only if they are a Junior or Senior (if their credits are greater than 60, as you wrote). You are returning the desired major if they are a Junior or Senior instead of setting it.

This should work:

set major(major) {
  if (this.credits > 60) {
   this._major = major; 
  } else {
    this._major = 'none';
  }
}
Leah Miller
Leah Miller
16,291 Points
Leah Miller
Leah Miller
16,291 Points

Thanks so much. I think I didn't understand the code quite as I should have but that worked and think I understand setters a little better!