Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python Django Authentication Users and Authorization Add to Group

Natan Becker
Natan Becker
7,044 Points

Add new editor user to Editors group

I'm sure that i'm creating the editors group and give it the right permissions, but it didn't passed, anybody can help me please?

accounts/models.py
from django.contrib.auth.models import (
    PermissionsMixin,
    BaseUserManager,
    AbstractBaseUser,
    Permission,
    Group
)
from django.db import models
from django.utils import timezone
from django.shortcuts import get_object_or_404

class UserManager(BaseUserManager):
    def create_user(self, email, dob, accepted_tos=None, password=None):
        if not accepted_tos:
            raise ValueError("Users must accept the terms of service")

        user = self.model(
            email=self.normalize_email(email),
            dob=dob,
            accepted_tos=True
        )
        user.set_password(password)
        user.save()
        return user

    def create_superuser(self, email, dob, password):
        user = self.create_user(
            email,
            dob,
            accepted_tos=True,
            password=password
        )
        user.is_staff = True
        user.is_superuser = True
        user.save()
        return user

    def create_editor(self, email, dob, password):
        user = self.create_user(
            email,
            dob,
            accepted_tos=True,
            password=password
        )

        try:
            editors = Group.objects.get(name__iexact="Editors")
            user.groups.add(editors)
            user.save()
        except Group.DoesNotExist:
            editors = Group.objects.create(name="Editors")
            editors.permissions.add(Permissions.objects.get(codename="can_give_discount"))
            user.groups.add(editors)
            user.save()






class User(AbstractBaseUser, PermissionsMixin):
    email = models.EmailField(unique=True)
    dob = models.DateField()
    accepted_tos = models.BooleanField()
    is_staff = models.BooleanField(default=False)
    joined_at = models.DateTimeField(default=timezone.now)

    objects = UserManager()

    USERNAME_FIELD = "email"
    REQUIRED_FIELDS = ["dob"]
Natan Becker
Natan Becker
7,044 Points

Kenneth Love could you please help me please?

2 Answers

Kenneth Love
STAFF
Kenneth Love
Treehouse Guest Teacher

Ugh, one of the short comings of our testing setup. Permissions should be Permission. I need to find a way to bubble up exceptions from inside of tests.

Natan Becker
Natan Becker
7,044 Points

Kenneth Love So the solution is only change Permissions to Permission? Cause i've change it, but it sitll failed. I don't if i have to get the try catch in de "def get" function like you did in the video

Kenneth Love
Kenneth Love
Treehouse Guest Teacher

You need to use Permission instead of Permissions, since that's the actual model name. You also should return the user from your create_editor method. That passed for me.

Natan Becker
Natan Becker
7,044 Points

Kenneth Love Thanks a lot kenneth it works, I totally forgot return the user.