C# Objects Code Challenge: Magic Numbers and Constants

I agree that this exercise is to put it mildly pretty bad, arguably one of the worst I have seen on treehouse.

Anyway, as it seems you have gathered from the code you have written. The objective of the challenge is to replace all strings and number with variables. The challenge is indeed not explained very well. And while excessive use of magic numbers and strings is something that is not ideal, having a certain number of them is perfectly normal. Converting every single number and string to a variable is a contrived task that would never be done in a real application.

But I digress, your solution is almost entirely correct. But the revenue declaration seems to have gotten messed up at some point while you were trying to figure out what to do. At the start of the challenge the revenue variable is declared like this:

const int revenue = 125000;

And it's one of the variables that you should not touch at all. Besides that your code is correct. So if you change the revenue variable like so:

const int revenue = 125000;
string status = null;
const int revenue1 = 100000;
const int revenue2 = 150000;
const string status1 = "red";
const string status2 = "yellow";
const string status3 = "green";

if (revenue < revenue1) {
    status = status1; 
} else if (revenue < revenue2) {
    status = status2; 
} else {
    status = status3; 
}

Then your code will pass.