Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python

Sabine Lazuhina
Sabine Lazuhina
2,334 Points

Can someone please advise where did I get wrong in my class method definition?

Can someone please advise where did I get wrong in my class method definition? Many thanks, Sabine

morse.py
class Letter:
    def __init__(self, pattern=None):
        self.pattern = pattern

    def __iter__(self):
        yield from self.pattern

    def __str__(self):
        output = []
        for blip in self:
            if blip == '.':
                output.append('dot')
            else:
                output.append('dash')
        return '-'.join(output)

    @classmethod:
        def from_string(cls, output):
            stringList = output.split('-')
            pattern = []
            for item in stringList:
                if item == 'dash':
                    pattern.append('-')
                elif item == 'dot':
                    pattern.append('.')
                else:
                    pass
            return cls(pattern)


class S(Letter):
    def __init__(self):
         pattern = ['.', '.', '.']
         super().__init__(pattern)

1 Answer

Steven Parker
Steven Parker
231,248 Points

You're pretty close! But I see 3 issues:

  • the "@classmethod" decorator doesn't need a colon
  • the definition (everything after the decorator) is indented too far
  • a "dash" is being represented by a hyphen ("-") instead of an underscore ("_")