Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python

Akshaan Mazumdar
Akshaan Mazumdar
3,787 Points
Posted by Akshaan Mazumdar
Akshaan Mazumdar
3,787 Points

Code not working

Please check the @classmethod. Challenge is not passing. Thanks

morse.py 
class Letter:
    def __init__(self, pattern=None):
        self.pattern = pattern

    def __iter__(self):
        yield from self.pattern

    def __str__(self):
        output = []
        for blip in self:
            if blip == '.':
                output.append('dot')
            else:
                output.append('dash')
        return '-'.join(output)


    @classmethod
    def from_string(cls,strx):
        x=strx.split('-')
        xx=[]
        for y in x:
            if y == "dash":
                xx.append('-')
            else:
                xx.append('.')

        pattern=xx


 class S(Letter):
    def __init__(self):
         pattern = ['.', '.', '.']
         super().__init__(pattern)

1 Answer

Steven Parker
Steven Parker
231,248 Points
Steven Parker
Steven Parker
231,248 Points

You're close, but your method needs to create and return a new instance with the pattern loaded into it. So the final line of the method should be something like this:

        return cls(xx)

Then, the one other issue is that instead of a hyphen, a "dash" should be represented in the pattern as an underscore ("_").

Akshaan Mazumdar
Akshaan Mazumdar
3,787 Points
Akshaan Mazumdar
Akshaan Mazumdar
3,787 Points

Thanks Steven Parker !! . Your answers have really helped me learn and finish Object Oriented Python quickly!!