Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python Object-Oriented Python Dice Roller RPG Roller

Posted by asafitch
asafitch
3,796 Points

Code works locally, but doesn't pass the test. Feedback isn't verbose, so not clear what's up.

This seems to fulfill the specifications, and works on my local machine, but apparently isn't "correct." Anyone know what's going on?

import random


class Die:
    def __init__(self, sides=2):
        if sides < 2:
            raise ValueError("Can't have fewer than two sides")
        self.sides = sides
        self.value = random.randint(1, sides)

    def __int__(self):
        return self.value

    def __add__(self, other):
        return int(self) + other

    def __radd__(self, other):
        return self + other

class D20(Die):
    def __init__(self):
        super().__init__(sides=20)

class Hand(list):
    @property
    def total(self):
        total = 0
        for item in self:
            total += int(item)
        return total

    def roll(dice=1):
        result_hand = Hand()
        for _ in range(dice):
            result_hand.append(D20())
        return result_hand
dice.py 
import random

class Die:
    def __init__(self, sides=2):
        if sides < 2:
            raise ValueError("Can't have fewer than two sides")
        self.sides = sides
        self.value = random.randint(1, sides)

    def __int__(self):
        return self.value

    def __add__(self, other):
        return int(self) + other

    def __radd__(self, other):
        return self + other


class D20(Die):
    def __init__(self):
        super().__init__(sides=20)
hands.py 
class Hand(list):
    @property
    def total(self):
        total = 0
        for item in self:
            total += int(item)
        return total

    def roll(dice=1):
        result_hand = Hand()
        for _ in range(dice):
            result_hand.append(D20())
        return result_hand
nakalkucing
nakalkucing
12,964 Points
nakalkucing
nakalkucing
12,964 Points

Hi asafitch! You have not imported D20 from dice at the top of your hands.py. Once you have, you will get more explicit feedback. Hope this helps, and good luck with your coding! :)

1 Answer

Alexander Davison
Alexander Davison
65,469 Points
Alexander Davison
Alexander Davison
65,469 Points

The only problem I can see is that your missing @classmethod before the roll definition. Unfortunately, it seems that it still does not work even if you add that. I am unsure of the reason why, so I'll leave the rest up to somebody else to answer! :confused: