Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python

andrea kalifa
seal-mask
.a{fill-rule:evenodd;}techdegree
andrea kalifa
Python Web Development Techdegree Student 2,935 Points
Posted by andrea kalifa
.a{fill-rule:evenodd;}techdegree
andrea kalifa
Python Web Development Techdegree Student 2,935 Points

Define setter property

I'm test and re-test my code and always I'm getting right price value.

Challenge give me the follow problem: "Bummer: Didn't correctly set the @price property"

And really, I don't know why..

product.py 
class Product:
    _price = 0.0
    tax_rate = 0.12

    def __init__(self, base_price):
        self._price = base_price

    @property
    def price(self):
        return self._price + (self._price * self.tax_rate)

    @price.setter
    def price(self, price):
        self._price = price / (self.tax_rate + 1)

2 Answers

Steven Parker
Steven Parker
231,248 Points
Steven Parker
Steven Parker
231,248 Points

You got too fancy! The challenge wants a setter "that updates the _price attribute". What they mean is that it should directly update the attribute, without making any tax calculations on it.

andrea kalifa
seal-mask
.a{fill-rule:evenodd;}techdegree
andrea kalifa
Python Web Development Techdegree Student 2,935 Points
andrea kalifa
.a{fill-rule:evenodd;}techdegree
andrea kalifa
Python Web Development Techdegree Student 2,935 Points

Ok nice, but I'm confuse.

If I get price by "self._price + (self._price * self.tax_rate)"

when I set directly price by @price.setter, to get updated _price, shouldn't I make inverse calculation?

For example:

price = 5 tax = 1 total price = price + tax = 6

If I update total price to 10 , my updated price should be 9 right?

Steven Parker
Steven Parker
231,248 Points
Steven Parker
Steven Parker
231,248 Points

I can understand the confusion, but they don't want an inverse calculation (though you did a great job on that!). They just want a way to update the base price itself.

Happy coding!