Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python Object-Oriented Python Dice Roller RPG Roller

Posted by Sunny Sun
.a{fill-rule:evenodd;}techdegree
Sunny Sun
Python Development Techdegree Student 7,241 Points

Dice roll challenge

I think I got most of this but I'm stuck on what is wrong with my code

dice.py 
import random


class Die:
    def __init__(self, sides=2):
        if sides < 2:
            raise ValueError("Can't have fewer than two sides")
        self.sides = sides
        self.value = random.randint(1, sides)

    def __int__(self):
        return self.value

    def __add__(self, other):
        return int(self) + other

    def __radd__(self, other):
        return self + other

class D20(Die):
    def __init__(self):
        super().__init__(sides=20)
hands.py 
from dice import D20

class Hand(list):
    def __init__(self, size=None, die_class=D20):
        size = super().__init__()
         for _ in range(size):
            self.append(die_class())

    @property
    def total(self):
        return sum(self)

    @classmethod
    def roll(cls, num_dice=2):
        return cls(size=num_dice)

1 Answer

Steven Parker
Steven Parker
231,248 Points
Steven Parker
Steven Parker
231,248 Points

You won't need to override "__init__" here, all the work can be done in the "roll" method.

Plus the "super" version doesn't return anything when you call it.

Sunny Sun
.a{fill-rule:evenodd;}techdegree
Sunny Sun
Python Development Techdegree Student 7,241 Points

I changed it to

class Hand(list): @property def total(self): return sum(self)

@classmethod
def roll(cls, num_of_dice):
    emp = []
    for _ in range(num_of_dice):
        emp.append(D20())
    return cls(emp)

But it still isn't passing

Steven Parker
Steven Parker
231,248 Points
Steven Parker
Steven Parker
231,248 Points

Odd, that looks OK. So I copied and pasted it directly into the challenge and it passed!