Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python Customizing the Django Admin Customizing the List View Test: Custom Filters

Chris Komaroff
PLUS
Chris Komaroff
Courses Plus Student 14,198 Points
Posted by Chris Komaroff
Chris Komaroff
Courses Plus Student 14,198 Points

Django Admin Custom Filter Error?

Challenge Task 3 of 4

"Create the queryset method. Remember that this method takes in self, request, and queryset as arguments. In the method, check to see if self.value() returns anything. If it does, .filter() the queryset for records where the title contains the value. Use contains for the comparison."

I am not passing 3 of 4.

Error message: "Bummer! The queryset() method needs to call filter() on its 'queryset' argument."

The code looks okay. Maybe I am not reading the question correctly? Everything above 'def queryset()' passed 1 of 4, and 2 of 4. I realize the filter will be registered with CourseAdmin in step 4 of 4, I even tried to register it as such but no luck.

class TopicListFilter(admin.SimpleListFilter):
    title = 'topic'
    parameter_name = 'topic'

    def lookups(self, request, model_admin):
        return (
            ('Python', 'Python'),
            ('Ruby', 'Ruby'),
            ('Java', 'Java'),
        )

    def queryset(self, request, queryset):
        if self.value() == 'Python':
            return queryset.filter(title__contains='Python')
        if self.value() == 'Ruby':
            return queryset.filter(title__contains='Ruby')
        if self.value() == 'Java':
            return queryset.filter(title__contains='Java')
courses/admin.py 
from django.contrib import admin

from . import models

class TextInline(admin.StackedInline):
    model = models.Text

class QuizInline(admin.StackedInline):
    model = models.Quiz

class AnswerInline(admin.StackedInline):
    model = models.Answer

class TopicListFilter(admin.SimpleListFilter):
    title = 'topic'
    parameter_name = 'topic'

    def lookups(self, request, model_admin):
        return (
            ('Python', 'Python'),
            ('Ruby', 'Ruby'),
            ('Java', 'Java'),
        )

    def queryset(self, request, queryset):
        if self.value() == 'Python':
            return queryset.filter(title__contains='Python')
        if self.value() == 'Ruby':
            return queryset.filter(title__contains='Ruby')
        if self.value() == 'Java':
            return queryset.filter(title__contains='Java')

class CourseAdmin(admin.ModelAdmin):
    inlines = [TextInline, QuizInline]

    list_filter = ['created_at', 'is_live']

admin.site.register(models.Course, CourseAdmin)

2 Answers

Chris Komaroff
PLUS
Chris Komaroff
Courses Plus Student 14,198 Points
Chris Komaroff
Chris Komaroff
Courses Plus Student 14,198 Points

Hi all, I just figured out how to pass 3 of 4. The following code for queryset() method passed. I think this is weird. My testing shows self.value() case must be identical to the lookup tuple value case, i.e. 'Python' != 'python', so this code would not work in real world? If someone can explain why this code should work let me know, but it crashes for me (but it passes the code challenge 3 of 4).

class TopicListFilter(admin.SimpleListFilter):
    title = 'topic'
    parameter_name = 'topic'

    def lookups(self, request, model_admin):
        return (
            ('Python', 'Python'),
            ('Ruby', 'Ruby'),
            ('Java', 'Java'),
        )

    def queryset(self, request, queryset):
        if self.value() == 'python':
            return queryset.filter(title__contains='python')
        if self.value() == 'ruby':
            return queryset.filter(title__contains='ruby')
        if self.value() == 'java':
            return queryset.filter(title__contains='java')
Jasper Maposa
Jasper Maposa
26,918 Points
Jasper Maposa
Jasper Maposa
26,918 Points

For DRY purposes, I did this instead:

    def queryset(self, request, queryset):
        if self.value():
            return queryset.filter(title__contains=self.value())