I cannot see what's wrong here -ScrabblePlayer

Question

Hi, Could you please point out the errors in this code? I would like to know why it's not working.

ScrabblePlayer.java

public class ScrabblePlayer {
  // A String representing all of the tiles that this player has
  private String tiles;

  public ScrabblePlayer() {
    tiles = "";
  }

  public String getTiles() {
    return tiles;
  }

  public void addTile(char tile) {
    tiles += tile;
  }

  public boolean hasTile(char tile) {
    return tiles.indexOf(tile) != -1;
  }

  public int getCountOfLetter(char letter) {
    int hit = 0;
    for(char a : tiles.toCharArray()) {
      if(tiles.indexOf(a) == letter) {
        ++hit;
      }
    }
     return hit;
  } 
}

Example.java

// This code is here for example purposes only
public class Example {

  public static void main(String[] args) {
    ScrabblePlayer player1 = new ScrabblePlayer();
    player1.addTile('d');
    player1.addTile('d');
    player1.addTile('p');
    player1.addTile('e');
    player1.addTile('l');
    player1.addTile('u');

    ScrabblePlayer player2 = new ScrabblePlayer();
    player2.addTile('z');
    player2.addTile('z');
    player2.addTile('y');
    player2.addTile('f');
    player2.addTile('u');
    player2.addTile('z');

    int count = 0;
    // This would set count to 1 because player1 has 1 'p' tile in her collection of tiles
    count = player1.getCountOfLetter('p');
    // This would set count to 2 because player1 has 2 'd'' tiles in her collection of tiles
    count = player1.getCountOfLetter('d');
    // This would set 0, because there isn't an 'a' tile in player1's tiles
    count = player1.getCountOfLetter('a');

    // This will return 3 because player2 has 3 'z' tiles in his collection of tiles
    count = player2.getCountOfLetter('z');
    // This will return 1 because player2 has 1 'f' tiles in his collection of tiles
    count = player2.getCountOfLetter('f');
  }
}

Answer 1 · 2017-07-09T01:12:28Z

July 9, 2017 1:12am

Hi Trung, You are very close to solving the challenge, but are making a mistake with if(tiles.indexOf(a) == letter). You don't need to use indexOf, because you've already converted the private String tiles to an array of characters which you are iterating over. Because you will iterate over all of these characters, you can simply check if each of those tiles matches the passed in char letter parameter.

int count = 0;
for (char tile : this.tiles.toCharArray()) {
  if (tile == letter) count++;
}
return count;

Welcome to the Treehouse Community

Looking to learn something new?

Trung Bui Duc

Trung Bui Duc

I cannot see what's wrong here -ScrabblePlayer

1 Answer

samiff

samiff

Trung Bui Duc

Trung Bui Duc