Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Java Java Objects Delivering the MVP Applying a Discount Code

Angelos Kalandranis
Angelos Kalandranis
661 Points

I keep getting a message that the string is not be normalized.

When calling the order.applyDiscountCode the discountCode has not been normalized. How do I use the normalizing method to correct this? Or is there something else wrong in my approach.?

Order.java
public class Order {
  private String itemName;
  private int priceInCents;
  private String discountCode;

  public Order(String itemName, int priceInCents) {
    this.itemName = itemName;
    this.priceInCents = priceInCents;
  }

  public String getItemName() {
    return itemName;
  }

  public int getPriceInCents() {
    return priceInCents;
  }

  public String getDiscountCode() {
    return discountCode;
  }
private String normalizeDiscountCode(String discountCode) {
  this.discountCode= discountCode.toUpperCase();
 return discountCode;
}


  public void applyDiscountCode(String discountCode) {
    this.discountCode = normalizeDiscountCode(discountCode);
  }
}
Example.java
public class Example {

  public static void main(String[] args) {
    // This is here just for example use cases.

    Order order = new Order(
            "Yoda PEZ Dispenser",
            600);

    // These are valid.  They are letters and the $ character only
    order.applyDiscountCode("abc");
    order.getDiscountCode(); // ABC

    order.applyDiscountCode("$ale");
    order.getDiscountCode(); // $ALE


    try {
      // This will throw an exception because it contains numbers
      order.applyDiscountCode("ABC123");
    } catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }
    try {
      // This will throw as well, because it contains a symbol.
      order.applyDiscountCode("w@w");
    }catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }

  }
}

2 Answers

Hi there,

For the first task, just return the uppercase discountCode from the method; no other actions are required. Take the passed-in string, and return the upper case version of it. You set this.discountCode in the applyDiscountCode method, not in normalizeDiscountCode.

Steve.

calp
calp
10,317 Points

You're getting that message because you're not returning the parameter (the variable that is being passed into the method) in uppercase. I have written the correct code for you to look at,

private String normalizeDiscountCode(String discountCode) {
    return discountCode.toUpperCase();
}