Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python

Posted by Nathan English
.a{fill-rule:evenodd;}techdegree
Nathan English
Front End Web Development Techdegree Student 10,817 Points

I need help with this challenge!!!

Let's practice using @classmethod!

Create a class method in Letter named from_string that takes a string like "dash-dot" and creates an instance with the correct pattern (['_', '.']).

morse.py 
class Letter:
    def __init__(self, pattern=None):
        self.pattern = pattern

    def __iter__(self):
        yield from self.pattern

    def __str__(self):
        output = []
        for blip in self:
            if blip == '.':
                output.append('dot')
            else:
                output.append('dash')
        return '-'.join(output)

    @classmethod
    def from_string(cls,string):
        split_list = string.split('-')
        output = []
        for x in string:
            if x == "dot":
                output.append(".")
            else:
                output.append("_")
        return cls(output)


class S(Letter):
    def __init__(self):
         pattern = ['.', '.', '.']
         super().__init__(pattern)

3 Answers

Alexander Löwenmark
Alexander Löwenmark
1,664 Points
Alexander Löwenmark
Alexander Löwenmark
1,664 Points

Hello!

I think you should loop through the variable "split_list" instead of "string".

Nathan English
seal-mask
.a{fill-rule:evenodd;}techdegree
Nathan English
Front End Web Development Techdegree Student 10,817 Points
Nathan English
.a{fill-rule:evenodd;}techdegree
Nathan English
Front End Web Development Techdegree Student 10,817 Points

I fix that, and now for some reason my list is returning empty.

Nathan Garcia
Nathan Garcia
9,098 Points
Nathan Garcia
Nathan Garcia
9,098 Points 
    @classmethod
    def from_string(cls, self):
        split_list = self.split('-')
        output = []
        for blip in split_list:
            if blip == "dot":
                output.append(".")
            else:
                output.append("_")
        return cls(output)

You defined split list but don't use it. Try adding it to your loop.