Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Java Java Objects Creating the MVP Counting Scrabble Tiles

Posted by Robert eRS
Robert eRS
9,646 Points

I need some help

What is incorrect ?

ScrabblePlayer.java 
public class ScrabblePlayer {
  // A String representing all of the tiles that this player has
  private String tiles;

  public ScrabblePlayer() {
    tiles = "";
  }

  public String getTiles() {
    return tiles;
  }

  public void addTile(char tile) {
    tiles += tile;
  }

  public boolean hasTile(char tile) {
    return tiles.indexOf(tile) != -1;
  }

  public int getCountOfLetter(char letter){

    for (char letter : tiles.toCharArray()){
      int count = 0;
         for (int i=0; i < tiles.length(); i++){
           if (tiles.charAt(i) == letter){

             count++; 
         }
      return count;
    } 

  }
Example.java 
// This code is here for example purposes only
public class Example {

  public static void main(String[] args) {
    ScrabblePlayer player1 = new ScrabblePlayer();
    player1.addTile('d');
    player1.addTile('d');
    player1.addTile('p');
    player1.addTile('e');
    player1.addTile('l');
    player1.addTile('u');

    ScrabblePlayer player2 = new ScrabblePlayer();
    player2.addTile('z');
    player2.addTile('z');
    player2.addTile('y');
    player2.addTile('f');
    player2.addTile('u');
    player2.addTile('z');

    int count = 0;
    // This would set count to 1 because player1 has 1 'p' tile in her collection of tiles
    count = player1.getCountOfLetter('p');
    // This would set count to 2 because player1 has 2 'd'' tiles in her collection of tiles
    count = player1.getCountOfLetter('d');
    // This would set 0, because there isn't an 'a' tile in player1's tiles
    count = player1.getCountOfLetter('a');

    // This will return 3 because player2 has 3 'z' tiles in his collection of tiles
    count = player2.getCountOfLetter('z');
    // This will return 1 because player2 has 1 'f' tiles in his collection of tiles
    count = player2.getCountOfLetter('f');
  }
}

1 Answer

markmneimneh
markmneimneh
14,132 Points

Hello

I believe the problem is here:

public int getCountOfLetter(char letter){

for (char letter : tiles.toCharArray()){
  int count = 0;
     for (int i=0; i < tiles.length(); i++){
       if (tiles.charAt(i) == letter){

         count++; 
     }
  return count;
}

}

You are passing letter as an argument to the method ...getCountOfLetter(char letter)

but at the same time you are using letter in the body of the for loop .... sort of confusing.

Also, you return count should be right before the method closing }

try this (not tested)

public int getCountOfLetter(char letter) {
    int count = 0;
    for (char aLetter : tiles.toCharArray()) {
        if (aLetter == letter) {
            count++;
        }
    }
    return count;
}

if this answers your question, please mark the question as answered.

Thank you