Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python

Mikkel Bielefeldt
Mikkel Bielefeldt
3,227 Points
Posted by Mikkel Bielefeldt
Mikkel Bielefeldt
3,227 Points

I think I'm very close

I think I'm very close with this code, but it still seems like it's not right.

morse.py 
class Letter:
    def __init__(self, pattern=None):
        self.pattern = pattern

    def __iter__(self):
        yield from self.pattern

    def __str__(self):
        output = []
        for blip in self:
            if blip == '.':
                output.append('dot')
            else:
                output.append('dash')
        return '-'.join(output)

    @classmethod
        def from_string(cls, str):
            split_str = str.split('-')
            list = []
            for x in split_str:
                    if x == 'dash':
                        list.append('_')
                    elif x == 'dot':
                        list.append('.')
                return cls(list)

class S(Letter):
    def __init__(self):
         pattern = ['.', '.', '.']
         super().__init__(pattern)

1 Answer

Steven Parker
Steven Parker
231,248 Points
Steven Parker
Steven Parker
231,248 Points

You are very close indeed!
Your only issue is with indentation, just fix your alignment and you'll pass the challenge. :+1:

Just be sure to use consistent indentation amounts for each level, and not to mix spaces and tabs. And the "def" line should be in the same column as the "@classmethod" decorator.

Mikkel Bielefeldt
Mikkel Bielefeldt
3,227 Points
Mikkel Bielefeldt
Mikkel Bielefeldt
3,227 Points

Have fixed it, and now it says "Didn't get the right pattern". Tried to post my code, but it got messed up. Please write your version of it.

Steven Parker
Steven Parker
231,248 Points
Steven Parker
Steven Parker
231,248 Points

I saw it, and without Markdown formatting it's hard to be certain; but it looked like the "return" line might still be indented one level too far.

For future postings, here is a video on code formatting.