Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Java Java Objects Delivering the MVP Applying a Discount Code

DIVYA TANDON
DIVYA TANDON
1,374 Points

In the normalizeDiscountCode verify that only letters or the $ character are used. If any other character is used, throw

In the normalizeDiscountCode verify that only letters or the $ character are used. If any other character is used, throw a IllegalArgumentException with the message Invalid discount code.

Order.java
public class Order {
  private String itemName;
  private int priceInCents;
  private String discountCode;

  public Order(String itemName, int priceInCents) {
    this.itemName = itemName;
    this.priceInCents = priceInCents;
  }


  public String getItemName() {
    return itemName;
  }

  public int getPriceInCents() {
    return priceInCents;
  }

  public String getDiscountCode() {
    return discountCode;
  }

  public void applyDiscountCode(String discountCode) {
    this.discountCode = normalizeDiscountCode(discountCode);

  }

   private String normalizeDiscountCode (String discountCode)  {

     if ( String.contains('$') || 

    {
      throw new IllegalArgumentException("Invalid discount code");
        }

     return discountCode.toUpperCase();   
}
}
Example.java
public class Example {

  public static void main(String[] args) {
    // This is here just for example use cases.

    Order order = new Order(
            "Yoda PEZ Dispenser",
            600);

    // These are valid.  They are letters and the $ character only
    order.applyDiscountCode("abc");
    order.getDiscountCode(); // ABC

    order.applyDiscountCode("$ale");
    order.getDiscountCode(); // $ALE


    try {
      // This will throw an exception because it contains numbers
      order.applyDiscountCode("ABC123");
    } catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }
    try {
      // This will throw as well, because it contains a symbol.
      order.applyDiscountCode("w@w");
    }catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }

  }
}
Simon Coates
Simon Coates
28,694 Points

for starters, you're attempting to call contains on the class String, not the variable discountCode. I've included some code that seems to pass the test below. I think the key point is working out which string methods are helpful and which methods on the Character class are helpful.

1 Answer

Simon Coates
Simon Coates
28,694 Points

my guess is:

   private String normalizeDiscountCode(String discountCode) {//throws IllegalArgumentException {
     for(char c: discountCode.toCharArray()){
       if(c!= '$' && !Character.isLetter(c)){
         throw new IllegalArgumentException("Invalid discount code");
       }
    }
     return discountCode.toUpperCase();
   }

You can check https://teamtreehouse.com/community/code-challenge:16332 to see what over people came up with

Mark James Lagarita
Mark James Lagarita
1,639 Points

Thanks Simon Coates! This is exactly what I'm looking for. I've pretty much figured out what I wanna do for my "if" statement, but could not come up with a solid yet very readable code to call the variable discountCode.