Infinite loop Happening with the Fly Instance

Question

Not sure why this is happening. Every time I play the game, there is a infinite amount of flies being generated by the fly spawner. I checked the script, everything seems to be ok. But the game still does not stop even with when the while condition is met.

using UnityEngine; using System.Collections;

public class FlySpawner : MonoBehaviour {

[SerializeField]
private GameObject flyPrefab;

[SerializeField]
private int FlyMinimum = 12;

private float spawnArea = 25f;

public static int totalFlies;

// Use this for initialization
void Start () {
    totalFlies = 0;
}

// Update is called once per frame
void Update () {

    //While the total number of flies is less than the minimum...
    while ( totalFlies < FlyMinimum ) {

        //...then increment the total number of flies...
        totalFlies++;

        //...create a random position for a fly...
        float positionX = Random.Range (-spawnArea, spawnArea);
        float positionZ = Random.Range (-spawnArea, spawnArea);

        Vector3 flyPosition = new Vector3(positionX, 2f, positionZ);

        //..and create a new fly
        Instantiate (flyPrefab, flyPosition, Quaternion.identity);
    }
}

}

Answer 1 · 2016-07-11T02:22:22Z

July 11, 2016 2:22am

I'd be suspicious that some other part of the code was altering totalFlies or FlyMinimum. Have you tried logging both those values at the beginning of the loop?

Also, is there anywhere else in the code where flies can be spawned? Maybe it's not even happening in this function.

Answer 2 · 2016-07-11T19:44:15Z

July 11, 2016 7:44pm

Hey Steven,

Thanks for answer.

Found the error, turns out unity was pointing at an old instance of my fly spawner. Had to remove the game manager, remove the fly spawner and just rewrite.

Also curious to know why use a while loop when they could have used a if since we only want 12 flies active at one time?

Answer 3 · 2016-07-11T19:50:44Z

July 11, 2016 7:50pm

An if would create at most one fly. So if you already had 2, you'd end up with 3.

The while continues to create flies until the count is equal to FlyMinimum (12). So if you already had 2, you still end up with 12.

Answer 4 · 2016-07-11T19:56:39Z

July 11, 2016 7:56pm

Ahh i see what you mean. Thanks for the clarification.

Welcome to the Treehouse Community

Looking to learn something new?

Barry Lam

Barry Lam

Infinite loop Happening with the Fly Instance

4 Answers

Steven Parker

Steven Parker

Barry Lam

Barry Lam

Steven Parker

Steven Parker

Barry Lam

Barry Lam