IntelliJ compiles and runs correctly, but Java heap error in code challenge window.

Question

The code solution is compiling and running just fine in IntelliJ, but when the same code is posted in the code challenge window, the compiler has a hitch. It seems the Java heap is too small to run the program. Is that because the code challenge program has set the heap too small, or is there a run-time problem in this code that I've missed due to IntelliJ being too lenient with a real issue?

com/teamtreehouse/Main.java

package com.teamtreehouse;

import java.util.Arrays;
import java.util.List;

public class Main {

    public static void main(String[] args) {
        Prompter prompter = new Prompter();
        prompter.run();
    }
}

com/teamtreehouse/Prompter.java

package com.teamtreehouse;

import java.io.BufferedReader;
import java.io.IOException;
import java.io.InputStreamReader;
import java.nio.file.Files;
import java.nio.file.Path;
import java.nio.file.Paths;
import java.util.ArrayList;
import java.util.HashSet;
import java.util.List;
import java.util.Set;


public class Prompter {
    private BufferedReader mReader;
    private Set<String> mCensoredWords;

    public Prompter() {
        mReader = new BufferedReader(new InputStreamReader(System.in));
        loadCensoredWords();
    }

    private void loadCensoredWords() {
        mCensoredWords = new HashSet<String>();
        Path file = Paths.get("resources", "censored_words.txt");
        List<String> words = null;
        try {
            words = Files.readAllLines(file);
        } catch (IOException e) {
            System.out.println("Couldn't load censored words");
            e.printStackTrace();
        }
        mCensoredWords.addAll(words);
    }

    public void run() {
        String temp = null;
        List<String> results = null;
        try {
            temp = promptForTemplate();
        } catch (IOException e) {
            System.out.println("There was a problem prompting for template");
            e.printStackTrace();
            System.exit(0);
        }
        Template tmpl = new Template(temp);
        try {
            results = promptForWords(tmpl);
        } catch (IOException e) {
            System.out.println("There was a problem prompting for words");
            e.printStackTrace();
            System.exit(0);
        }
        System.out.printf("Your TreeStory:%n%n%s", tmpl.render(results));
    }

    private String promptForTemplate() throws IOException {
        String temp = "";
        System.out.print("Please enter a template: ");
        temp = mReader.readLine();
        return temp;
    }

    /**
     * Prompts user for each of the blanks
     *
     * @param tmpl The compiled template
     * @return
     * @throws IOException
     */
    public List<String> promptForWords(Template tmpl) throws IOException {
        List<String> words = new ArrayList<String>();
        for (String phrase : tmpl.getPlaceHolders()) {
            String word = promptForWord(phrase);
            words.add(word);
        }
        return words;
    }


    /**
     * Prompts the user for the answer to the fill in the blank.  Value is guaranteed to be not in the censored words list.
     *
     * @param phrase The word that the user should be prompted.  eg: adjective, proper noun, name
     * @return What the user responded
     */
    public String promptForWord(String phrase) throws IOException {
        boolean goodInput = true;
        String input = "";
        do {
            System.out.printf("Please enter a %s: ",phrase);
            input = mReader.readLine();
            if(mCensoredWords.contains(input))
                {
                    goodInput = false;
                    System.out.println("Sorry, that's a censored word!");
                }
        }
        while(goodInput==false);
        return input;
    }
}

pseudo-tests.md

#  This is essentially what I am testing 
1.  The user is prompted for a new string template (the one with the double underscores in it).

  a. The prompter class has a new method that prompts for the story template, and that method is called.

2.  The user is then prompted for each word that has been double underscored.

   a. The answer is checked to see if it is contained in the censored words.
      User is continually prompted until they enter a valid word

3.  The user is presented with the completed story

Answer 1 · 2015-08-01T00:06:45Z

August 1, 2015 12:06am

In your promptForWord() method I see you are setting goodInput to false when you encounter a censored word but don't ever set it back to true inside the loop. Since the loop condition is while goodInput is false, it will cause an infinite loop when you encounter just one censored word.

Welcome to the Treehouse Community

Looking to learn something new?

Courtney Miller

Courtney Miller

IntelliJ compiles and runs correctly, but Java heap error in code challenge window.

1 Answer

Seth Kroger

Seth Kroger

Courtney Miller

Courtney Miller