Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript Loops Working with 'for' Loops The Refactor Challenge – Duplicate Code

Posted by Diego Alvarez
Diego Alvarez
6,680 Points

Is this solution ok?

So I called the Math.random function inside the randomRGB function instead of inside the call at the for loop. Is this ok or a bad practice? Thanks!

let html = '';
let main = document.querySelector('main');

let color = () => Math.floor(Math.random() * 256);

function randomRGB() {
  return `rgb( ${color()}, ${color()}, ${color()} )`;
}

for (let number = 1; number <= 10; number++) {
  html += `<div style="background-color: ${randomRGB()}">${number}</div>`;
}

main.innerHTML = html;
console.log(html);

3 Answers

Adam VanSlyke
Adam VanSlyke
15,988 Points
Adam VanSlyke
Adam VanSlyke
15,988 Points

I personally like how it reads, but I'm not experienced enough to know if its a bad practice.

Ignacio Rocha
Ignacio Rocha
7,462 Points
Ignacio Rocha
Ignacio Rocha
7,462 Points

is not a bad practice is just another kind of solution. But it's a better practice to create an arrow function declaration with 'const' instead of 'let' because you'll never reassigned a value to it.

kevin hudson
PLUS
kevin hudson
Courses Plus Student 11,987 Points
kevin hudson
kevin hudson
Courses Plus Student 11,987 Points

This is very good and less code than mine. I also did the arrow functions.