Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Java Java Objects Delivering the MVP Applying a Discount Code

Nikola Simic
Nikola Simic
2,143 Points

It compiles but why isnt it correct?

private String normalizeDiscountCode(String discountCode) {

int countIllegalLetters = 0;
for (char letter : discountCode.toCharArray()) {
  if(!Character.isLetter(letter) || letter != '$')
    countIllegalLetters++;
}
if (countIllegalLetters > 0) 
  throw new IllegalArgumentException("Invalid discount code.");

return discountCode.toUpperCase(); 

}

Order.java
public class Order {
  private String itemName;
  private int priceInCents;
  private String discountCode;

  private String normalizeDiscountCode(String discountCode) {

    int countIllegalLetters = 0;
    for (char letter : discountCode.toCharArray()) {
      if(!Character.isLetter(letter) || letter != '$')
        countIllegalLetters++;
    }
    if (countIllegalLetters > 0) 
      throw new IllegalArgumentException("Invalid discount code.");

    return discountCode.toUpperCase(); 
  }

  public Order(String itemName, int priceInCents) {
    this.itemName = itemName;
    this.priceInCents = priceInCents;
  }

  public String getItemName() {
    return itemName;
  }

  public int getPriceInCents() {
    return priceInCents;
  }

  public String getDiscountCode() {
    return this.discountCode;
  }

  public void applyDiscountCode(String discountCode) {
      this.discountCode = normalizeDiscountCode(discountCode);
  }
}
Example.java
public class Example {

  public static void main(String[] args) {
    // This is here just for example use cases.

    Order order = new Order(
            "Yoda PEZ Dispenser",
            600);

    // These are valid.  They are letters and the $ character only
    order.applyDiscountCode("abc");
    order.getDiscountCode(); // ABC

    order.applyDiscountCode("$ale");
    order.getDiscountCode(); // $ALE


    try {
      // This will throw an exception because it contains numbers
      order.applyDiscountCode("ABC123");
    } catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }
    try {
      // This will throw as well, because it contains a symbol.
      order.applyDiscountCode("w@w");
    }catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }

  }
}

4 Answers

Vladut Astalos
Vladut Astalos
11,246 Points

In normalizeDiscountCode(), when you check 'if(!Character.isLetter(letter) || letter != '$')' change '||' with '&&'.

Nikola Simic
Nikola Simic
2,143 Points

It works now with your suggestion, but I don't get it. Shouldn't the condition for the exception to be that if either its not a letter OR it is the sign '$'?

Vladut Astalos
Vladut Astalos
11,246 Points

When I did this challenge that was my logic too, but if you think about it both condition have to be true. Think this way: let's suppose your first part of the condition is true (that means that 'letter' isn't actually a letter, so is a special character), and your second part is false (that means that 'letter' is actually '$') then the condition will pass even tho it shouldn't, because when you use OR operator is enough that only one condition to be true. Is a little bit confusing because you use the negation '!' so you actually flip the truth value of the conditions.

Nikola Simic
Nikola Simic
2,143 Points

Thanks, it makes sence now :)