Last error on TDD challenge doesn't pass

Question

Hi guys, please help me with this challange. I have managed to pass all other tests except one the last one.

 def test_performer_detail_view(self):
        '''The performer_detail view should:
           * return a 200
           * have self.performer in the context
           * use the songs/performer_detail.html template
           * show the string version of self.song in the template
        '''
        resp = self.client.get(reverse('songs:performer',
                                       kwargs={'pk': self.performer.pk}))
        self.assertEqual(resp.status_code, 200)
        self.assertEqual(resp.context['performer'], self.performer)
        self.assertTemplateUsed(resp, 'songs/performer_detail.html')
        self.assertContains(resp, str(self.song))

And the error that i get is

NoReverseMatch: Reverse for 'detail' with arguments '()' and k_p':1}' not found . 
1 pattern (s) tried : ['songs/song/(?P<pk>\\d+)/$']

I don't really understand it. Your assistance would be greatly appreciated.

songs/models.py

from django.db import models

# Write your models here
class Performer(models.Model):
    name = models.CharField(max_length=100)

    def __str__(self):
        return self.name

class Song(models.Model):
    title = models.CharField(max_length=255)
    artist = models.CharField(max_length=100)
    performer = models.ForeignKey(Performer, max_length=100)
    length = models.IntegerField()

    def __str__(self):
        return '{} by {}'.format(self.title,self.artist)

songs/views.py

from django.shortcuts import render, get_object_or_404

from .models import Performer, Song

def song_list(request):
    songs = Song.objects.all()
    return render(request, 'songs/song_list.html', {'songs':songs})

def song_detail(request, pk):
    song = get_object_or_404(Song, pk=pk)
    return render(request, 'songs/song_detail.html', {'song': song})

def performer_detail(request, pk):
    performer = get_object_or_404(Performer, pk=pk)
    return render(request, 'songs/performer_detail.html', {'performer':performer})

songs/templates/songs/performer_detail.html

{% extends 'base.html' %}

{% block title %}{{ performer }}{% endblock %}

{% block content %}
<h2>{{ performer.name }}</h2>
    {% for song in performer.song_set.all %}
        <a href="{% url 'songs:detail' performer_pk=performer.pk song_pk=song.pk %}">song.title</a>
    {%endfor %}

{% endblock %}

Answer 1 · 2017-05-25T19:05:49Z

May 25, 2017 7:05pm

Right, I forgot that the url patterns were already set up for you.

I think the error might be caused by your href attribute in the performer_detail template. The song_detail view is expecting a single "pk" argument, but you are attempting to supply two arguments to the url lookup. (I think that is why the double backslash showed up in the error regarding that url. It was expecting a pk of some kind in between them.)

The challenge only specifies that you need to list the songs of each performer, not necessarily provide a link to them.

You should be able to get by simply by listing the song as its __str__ method. Example:

{% extends 'base.html' %}

{% block title %}{{ performer }}{% endblock %}

{% block content %}
  <h2>{{ performer }}</h2>
  {% for song in performer.song_set.all %}
    {{ song }}
  {% endfor %}
{% endblock %}

If you want to include a link, then you only need to supply the song pk argument, i.e., pk = song.pk. Since you are already on the performer_detail page and accessing the song_set of that particular performer, it won't be necessary to use the performer pk.

Also, don't forget that to access variables in a template you need to wrap them in double curly braces {{ }}.

I haven't actually tried running your code at all so I'm trying to debug it by just looking at it. But hopefully this will get us somewhere.

Answer 2 · 2017-05-25T17:14:34Z

May 25, 2017 5:14pm

Hi Ryan S or Chris Freeman , please help me with this.

Answer 3 · 2017-05-25T18:03:42Z

May 25, 2017 6:03pm

Hi Nthulane,

It might be helpful to post urls.py as well. But looking at your error I noticed that you have an extra backslash before the '\d+' characters.

['songs/song/(?P<pk>\\d+)/$']

#try removing the extra slash in song_detail url
'(?P<pk>\d+)/$'

Answer 4 · 2017-05-25T18:29:01Z

May 25, 2017 6:29pm

Hi Ryan!

Thanks for responding!

I don't think that that page matters because we don't change it but I understand why you'd want to see it.

from django.conf.urls import url

from . import views

urlpatterns = [
    url(r'performer/(?P<pk>\d+)/$', views.performer_detail, name='performer'),
    url(r'song/(?P<pk>\d+)/$', views.song_detail, name='detail'),
    url(r'', views.song_list, name='list'),
]

Looking forward to your response.

Answer 5 · 2017-05-25T19:19:36Z

May 25, 2017 7:19pm

You make some good points, especially the silly mistake with the missing {{ }}. I notice that i'm still a bit confused about the pk and when they should be used especially in template. I'll read up on them some.

Thanks for your response ;)

Welcome to the Treehouse Community

Looking to learn something new?

Nthulane Makgato

Nthulane Makgato

Last error on TDD challenge doesn't pass

5 Answers

Ryan S

Ryan S

Nthulane Makgato

Nthulane Makgato

Ryan S

Ryan S

Nthulane Makgato

Nthulane Makgato

Nthulane Makgato

Nthulane Makgato

Ryan S

Ryan S