Welcome to the Treehouse Community
Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.
Looking to learn something new?
Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.
Start your free trialJay McCormick
6,646 Pointslogout_user
Is there something I missed here? I thought this was pretty straightforward, but my code isn't passing.
from flask import Flask, g, render_template, flash, redirect, url_for
from flask.ext.bcrypt import check_password_hash
from flask.ext.login import LoginManager, login_user, current_user, login_required, logout_user
import forms
import models
app = Flask(__name__)
app.secret_key = 'this is our super secret key. do not share it with anyone!'
login_manager = LoginManager()
login_manager.init_app(app)
login_manager.login_view = 'login'
@login_manager.user_loader
def load_user(userid):
try:
return models.User.select().where(
models.User.id == int(userid)
).get()
except models.DoesNotExist:
return None
@app.before_request
def before_request():
g.db = models.DATABASE
g.db.connect()
g.user = current_user
@app.after_request
def after_request(response):
g.db.close()
return response
@app.route('/register', methods=('GET', 'POST'))
def register():
form = forms.SignUpInForm()
if form.validate_on_submit():
models.User.new(
email=form.email.data,
password=form.password.data
)
flash("Thanks for registering!")
return render_template('register.html', form=form)
@app.route('/login', methods=('GET', 'POST'))
def login():
form = forms.SignUpInForm()
if form.validate_on_submit():
try:
user = models.User.get(
models.User.email == form.email.data
)
if check_password_hash(user.password, form.password.data):
login_user(user)
flash("You're now logged in!")
else:
flash("No user with that email/password combo")
except models.DoesNotExist:
flash("No user with that email/password combo")
return render_template('register.html', form=form)
@app.route('/logout')
def logout():
logout_user()
return redirect(url_for('/login'))
@app.route('/secret')
@login_required
def secret():
return "I should only be visible to logged-in users"
1 Answer
Nathan Tallack
22,160 PointsYou were VERY close.
Take the leading / off your login url. Also it is a good idea to use the login_required decorator, just to be sure. ;)
Here is how your code would look with those changes.
@app.route('/logout')
@login_required
def logout():
logout_user()
return redirect(url_for('login'))
Jay McCormick
6,646 PointsJay McCormick
6,646 Pointsoh man that was close, but still so far! why no '/' in the url_for redirect?
Nathan Tallack
22,160 PointsNathan Tallack
22,160 PointsThe url_for will prefix the URL and then finish the prefix with a /. So you putting the / in there actually made it // which is why it was returning a 404. :)
Chris Freeman
Treehouse Moderator 68,441 PointsChris Freeman
Treehouse Moderator 68,441 PointsYou don't include slashes because the flask
url_for()
function "accepts the name of the function as first argument and a number of keyword arguments, each corresponding to the variable part of the URL rule. Unknown variable parts are appended to the URL as query parameters." [See docs]Nathan Tallack
22,160 PointsNathan Tallack
22,160 PointsYeah, like Chris said. :)
Thanks Chris.