Magic number and strings...

Question

I don't understand what I'm doing wrong, here is the question...
(Replace the magic numbers and strings in the if / else if / else statement with constants.)
And here is the error ( Bummer! Did you define a constant for the magic string 'red'?)
And here is my code
const int revenue = 125000;
string status = null;
const int rev1 = 100000;
const int rev2 = 150000;
const string red = "Red";
const string yellow = "Yellow";
const string green = "Green";
if (revenue < rev1)
{
    status = red;
}
else if (revenue < rev2)
{
    status = yellow;
}
else
{
    status = green;
}

Dale Bailey · Answer

Hi the problem is hard to see without proper markdown, at a glance it could be the value of the strings in your code starts with a capital letter (common trap on treehouse)
Heres the working code to compare.
```c#
const int revenue = 125000;
string status = null;
const string red = "red";
const string yellow = "yellow";
const string green = "green";
const int min = 100000;
const int max = 150000;
if (revenue < min)
{
    status = red;
}
else if (revenue < max)
{
    status = yellow;
}
else
{
    status = green;
}
```

Welcome to the Treehouse Community

Looking to learn something new?

Izzatilla Karimov

Izzatilla Karimov

Magic number and strings...

1 Answer

Dale Bailey

Dale Bailey