My Tacocat Triple-Fail (Logging in, Logging out, and Redirects)

I couldn't imagine what I would be doing to my instance of LoginManager that would cause this mess, but at this point it's the only thing I can think of. I knew it had to be something with the login manager, but the only two functions which required login were the only ones decorated as such (taco() and logout())

So I grabbed the flask login docs and tried all kinds of clever ways to suppress a behavior that didn't manifest itself in other scripts...because I tend to miss the obvious things. Like, it only manifests in THIS script, even though I've used that very same setup in other scripts. :)

login_manager = LoginManager()
login_manager.init_app(app)
login_manager.login_view = 'login'

So pretty standard, right? So when I changed the login_view to something else, it was still appending that query string to the url, and more importantly the base url was set to whatever I set login_view, to as if the login wasn't actually successful. I mean, it IS successful, in that it redirects successfully when the login form is filled out, it just didn't redirect to the right place. So I'm like, it HAS to be the login process, but I could not for the life of me figure out what the hell it was.

So it turns out when you do something really dumb like this:

@login_manager.user_loader
def load_user(userid):
    try:
        return models.User.get(models.User.email == userid)
    except models.DoesNotExist:
        return None

Then your login process works exactly as directed, but definitely not as intended :)

Replaced with the following, and it passes all tests:

@login_manager.user_loader
def load_user(userid):
  try:
    return models.User.get(models.User.id == userid)
  except models.DoesNotExist:
    return None

Scratch the 'add a new taco' bit, I modeled my code exactly as you posted and mine still passes all tests.

Thanks, I'll relaunch the workspace and see if I get the errors again, and then perhaps I'll try moving things around.

Capitalization shouldn't matter, given the test module checks against lower case strings. That's what really confused me about that particular error.

I know the capitalization shouldn't matter, but your code passing on my system exactly as written is a bit boggling.

I'm boggled, too, because the errors I'm looking at and the code I wrote seem to be at odds (particularly the text being on the page that's being tested for presence...)

I'll follow up in a minute once I run the workspace after it got a good night's sleep. :)

Looking more closely they're all predicated on a problem with the login function:

FAIL: test_taco_create (__main__.TacoViewsTestCase)
---------------------------------------------------------------------- 
Traceback (most recent call last):                                                           
  File "app_tests.py", line 145, in test_taco_create                                         
    self.assertEqual(rv.location, 'http://localhost/')                                       
AssertionError: 'http://localhost/login?next=%2Ftaco' != 'http://localhost/'                 
- http://localhost/login?next=%2Ftaco                                                        
+ http://localhost/  


FAIL: test_taco_create (__main__.TacoViewsTestCase)
----------------------------------------------------------------------                       
Traceback (most recent call last):                                                           
  File "app_tests.py", line 109, in test_logout                                              
    self.assertEqual(rv.location, 'http://localhost/')                                       
AssertionError: 'http://localhost/login?next=%2Flogout' != 'http://localhost/'               
- http://localhost/login?next=%2Flogout                                                      
+ http://localhost/       

Here's the login route. Maybe there's just some subtle thing I keep skipping over. :/ I have absolutely no idea why this is redirecting to a url with a GET query string instead of just redirecting to index.

@app.route('/login', methods=('GET', 'POST'))
def login():
  form = forms.LoginForm()
  if form.validate_on_submit():
    try:
      user = models.User.get(models.User.email == form.email.data)
    except models.DoesNotExist:
      flash("Email or password doesn't match")
    else:
      if check_password_hash(user.password, form.password.data):
        login_user(user)
        return redirect(url_for('index'))
  return render_template('login.html', form=form)

Brandon Meredith thanks for the assist on this. Once I knew I wasn't going crazy or having some unique workspaces issue it at least got me out of that rut and on a more productive path. :)