Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python Object-Oriented Python Dice Roller RPG Roller

Now update Hand in hands.py. I'm going to use code similar to Hand.roll(2) and I want to get back an instance of Hand wi

Using the code below, I get the error message 'Wrong length for hand'. Could someone please explain what I am doing wrong and how to fix it? Much appreciated.

dice.py
import random


class Die:
    def __init__(self, sides=2):
        if sides < 2:
            raise ValueError("Can't have fewer than two sides")
        self.sides = sides
        self.value = random.randint(1, sides)

    def __int__(self):
        return self.value

    def __add__(self, other):
        return int(self) + other

    def __radd__(self, other):
        return self + other

class D20(Die):
    def __init__(self, sides=20, *args, **kwargs):
        super().__init__(sides)
hands.py
from dice import D20

class Hand(list):
    def __init__(self,dice_list,*args, **kwargs):
        self = dice_list

    @classmethod
    def roll(cls,value):
        hand = []
        for _ in range(value):
            hand.append(D20())
        return cls(hand)


    @property
    def total(self):
        return sum(self)

1 Answer

Steven Parker
Steven Parker
230,995 Points

You don't need to override "__init__", and changing the calling signature (by adding a required argument) prevents the validation mechanism from successfully creating an instance.